diff options
| author | Linus Färnstrand <linus@mullvad.net> | 2024-03-20 17:19:14 +0100 |
|---|---|---|
| committer | Linus Färnstrand <linus@mullvad.net> | 2024-03-21 13:00:30 +0100 |
| commit | e0d48287b345e803b668ce9e3bc949fc71c766b5 (patch) | |
| tree | acaa97844c7557634811eebc32dc372fe77ae1ac /.github/workflows/git-commit-message-style.yml | |
| parent | 0b3760c116c370589a03e7f4edf9e16e612881e3 (diff) | |
| download | mullvadvpn-e0d48287b345e803b668ce9e3bc949fc71c766b5.tar.xz mullvadvpn-e0d48287b345e803b668ce9e3bc949fc71c766b5.zip | |
Reorder actions to not hide important failure
The mristin/opinionated-commit-message action can sometimes fail on
things we don't consider blocking/hard errors. Such as a correct
imperative verb that does not happen to be in the action's wordlist.
In these cases the job is aborted and the whitespace checking step is
never executed, leading to a larger risk of accidentally merging invalid
whitespaces
Diffstat (limited to '.github/workflows/git-commit-message-style.yml')
| -rw-r--r-- | .github/workflows/git-commit-message-style.yml | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/.github/workflows/git-commit-message-style.yml b/.github/workflows/git-commit-message-style.yml index 75e3565a86..6de2ffed44 100644 --- a/.github/workflows/git-commit-message-style.yml +++ b/.github/workflows/git-commit-message-style.yml @@ -9,16 +9,6 @@ jobs: name: Check commit message style runs-on: ubuntu-latest steps: - - name: Check against guidelines - uses: mristin/opinionated-commit-message@v3.1.0 - with: - # Commit messages are allowed to be subject only, no body - allow-one-liners: 'true' - # This action defaults to 50 char subjects, but 72 is fine. - max-subject-line-length: '72' - # The action's wordlist is a bit short. Add more accepted verbs - additional-verbs: 'restart, coalesce' - - name: Check for unicode whitespaces uses: gsactions/commit-message-checker@v2 with: @@ -30,3 +20,13 @@ jobs: error: 'Detected unicode whitespace character in commit message.' checkAllCommitMessages: 'true' # optional: this checks all commits associated with a pull request accessToken: ${{ secrets.GITHUB_TOKEN }} # only required if checkAllCommitMessages is true + + - name: Check against guidelines + uses: mristin/opinionated-commit-message@v3.1.0 + with: + # Commit messages are allowed to be subject only, no body + allow-one-liners: 'true' + # This action defaults to 50 char subjects, but 72 is fine. + max-subject-line-length: '72' + # The action's wordlist is a bit short. Add more accepted verbs + additional-verbs: 'restart, coalesce' |