diff options
| author | Markus Pettersson <markus.pettersson@mullvad.net> | 2024-07-23 10:10:48 +0200 |
|---|---|---|
| committer | Markus Pettersson <markus.pettersson@mullvad.net> | 2024-07-23 13:36:20 +0200 |
| commit | e37abd8299e49c7562a0bb5bdf79b1553b170f0f (patch) | |
| tree | a40fe9efbb377a5c7e9fa4026faaaf52a1b72ff4 /.github | |
| parent | be2c1aed13da9e25dbe81a5a54bd2d8a65a3904b (diff) | |
| download | mullvadvpn-e37abd8299e49c7562a0bb5bdf79b1553b170f0f.tar.xz mullvadvpn-e37abd8299e49c7562a0bb5bdf79b1553b170f0f.zip | |
Fix false negative in github action
Add a precondition to all os-specific test steps in the desktop
end-to-end test github action which checks if there are any vms to test
for the given os. . Without this check, the parsing of the vm names
assumed that there would exist atleast 1, causing the parsing to fail if
there were none. This would show up in the GitHub summary view as a
failure, while the intention was for it to be a noop.
Fix `yamllint`
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/desktop-e2e.yml | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/.github/workflows/desktop-e2e.yml b/.github/workflows/desktop-e2e.yml index fe084898f8..879d86e72b 100644 --- a/.github/workflows/desktop-e2e.yml +++ b/.github/workflows/desktop-e2e.yml @@ -126,7 +126,10 @@ jobs: e2e-test-linux: name: Linux end-to-end tests needs: [prepare-matrices, build-linux] - if: '!cancelled()' + if: | + !cancelled() && + needs.prepare-matrices.outputs.linux_matrix != '[]' && + needs.prepare-matrices.outputs.linux_matrix != '' runs-on: [self-hosted, desktop-test, Linux] # app-test-linux timeout-minutes: 240 strategy: @@ -196,7 +199,10 @@ jobs: e2e-test-windows: needs: [prepare-matrices, build-windows] - if: '!cancelled()' + if: | + !cancelled() && + needs.prepare-matrices.outputs.windows_matrix != '[]' && + needs.prepare-matrices.outputs.windows_matrix != '' name: Windows end-to-end tests runs-on: [self-hosted, desktop-test, Linux] # app-test-linux timeout-minutes: 240 @@ -263,7 +269,10 @@ jobs: e2e-test-macos: needs: [prepare-matrices, build-macos] - if: '!cancelled()' + if: | + !cancelled() && + needs.prepare-matrices.outputs.macos_matrix != '[]' && + needs.prepare-matrices.outputs.macos_matrix != '' name: macOS end-to-end tests runs-on: [self-hosted, desktop-test, macOS] # app-test-macos-arm timeout-minutes: 240 |