diff options
| author | Emīls Piņķis <emils@mullvad.net> | 2018-04-09 21:26:03 +0100 |
|---|---|---|
| committer | Emīls Piņķis <emils@mullvad.net> | 2018-04-10 15:15:10 +0100 |
| commit | 04902907d4b08834bfbcdb9cedbb846886b01765 (patch) | |
| tree | 89af7d955bd56df609faa2e3d3789b0bac47ed1f | |
| parent | bd6fd1a6905d15c27520479219b53d6dfc68aead (diff) | |
| download | mullvadvpn-04902907d4b08834bfbcdb9cedbb846886b01765.tar.xz mullvadvpn-04902907d4b08834bfbcdb9cedbb846886b01765.zip | |
Use BufReader for reading settings and relay list
| -rw-r--r-- | mullvad-daemon/src/relays.rs | 3 | ||||
| -rw-r--r-- | mullvad-daemon/src/settings.rs | 6 |
2 files changed, 5 insertions, 4 deletions
diff --git a/mullvad-daemon/src/relays.rs b/mullvad-daemon/src/relays.rs index 972a74e9ae..e5a56bf4f0 100644 --- a/mullvad-daemon/src/relays.rs +++ b/mullvad-daemon/src/relays.rs @@ -320,7 +320,8 @@ impl RelaySelector { ); let (last_modified, file) = Self::read_file(path.as_ref()).chain_err(|| ErrorKind::RelayCacheError)?; - let relay_list = serde_json::from_reader(file).chain_err(|| ErrorKind::SerializationError)?; + let relay_list = serde_json::from_reader(io::BufReader::new(file)) + .chain_err(|| ErrorKind::SerializationError)?; Ok((last_modified, relay_list)) } diff --git a/mullvad-daemon/src/settings.rs b/mullvad-daemon/src/settings.rs index d0023b59c1..9bf7245e03 100644 --- a/mullvad-daemon/src/settings.rs +++ b/mullvad-daemon/src/settings.rs @@ -62,9 +62,9 @@ impl Settings { pub fn load() -> Result<Settings> { let settings_path = Self::get_settings_path()?; match File::open(&settings_path) { - Ok(mut file) => { + Ok(file) => { info!("Loading settings from {}", settings_path.to_string_lossy()); - Self::read_settings(&mut file) + Self::read_settings(&mut io::BufReader::new(file)) } Err(ref e) if e.kind() == io::ErrorKind::NotFound => { info!( @@ -93,7 +93,7 @@ impl Settings { Ok(dir.join(SETTINGS_FILE)) } - fn read_settings(file: &mut File) -> Result<Settings> { + fn read_settings<T: io::Read>(file: &mut T) -> Result<Settings> { serde_json::from_reader(file).chain_err(|| ErrorKind::ParseError) } |
