diff options
| author | Tobias Järvelöv <tobias.jarvelov@mullvad.net> | 2025-04-03 21:38:30 +0200 |
|---|---|---|
| committer | Sebastian Holmin <sebastian.holmin@mullvad.net> | 2025-05-28 13:25:24 +0200 |
| commit | 0d3fdac763c8159fb37c969ed0daccfdfaa62616 (patch) | |
| tree | e8d1b0af8cfb3bc6c90779f4adb60cf1d8ecaf37 | |
| parent | cff7009c850d5965985236d51be7a0c5098f62f1 (diff) | |
| download | mullvadvpn-0d3fdac763c8159fb37c969ed0daccfdfaa62616.tar.xz mullvadvpn-0d3fdac763c8159fb37c969ed0daccfdfaa62616.zip | |
Refactor changelog view
- Add component to display "No changes for this platform"
- Reuse ChangeLogList component
- Reuse global redux selector hooks
- Move logic into hooks
3 files changed, 6 insertions, 14 deletions
diff --git a/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/ChangelogView.tsx b/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/ChangelogView.tsx index ff591c2fc1..8ebc20a262 100644 --- a/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/ChangelogView.tsx +++ b/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/ChangelogView.tsx @@ -9,14 +9,13 @@ import { Layout, SettingsContainer } from '../../Layout'; import { NavigationContainer } from '../../NavigationContainer'; import { NavigationScrollbars } from '../../NavigationScrollbars'; import { NoChangelogUpdates } from './components'; -import { useChangelog, useShowChangelogList, useShowNoChangelogUpdates } from './hooks'; +import { useChangelog, useShowChangelogList } from './hooks'; export const ChangelogView = () => { const { pop } = useHistory(); const { current } = useVersionCurrent(); const changelog = useChangelog(); const showChangelogList = useShowChangelogList(); - const showNoChangelogUpdates = useShowNoChangelogUpdates(); return ( <BackAction action={pop}> @@ -47,8 +46,11 @@ export const ChangelogView = () => { <TitleLarge as="h2">{current}</TitleLarge> </Container> <Container size="3" $flexDirection="column"> - {showChangelogList && <ChangelogList changelog={changelog} />} - {showNoChangelogUpdates && <NoChangelogUpdates />} + {showChangelogList ? ( + <ChangelogList changelog={changelog} /> + ) : ( + <NoChangelogUpdates /> + )} </Container> </Flex> </Flex> diff --git a/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/hooks/index.ts b/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/hooks/index.ts index 5f350effb0..fe20474c5d 100644 --- a/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/hooks/index.ts +++ b/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/hooks/index.ts @@ -1,4 +1,3 @@ export * from './useChangelog'; export * from './useHasChangelog'; export * from './useShowChangelogList'; -export * from './useShowNoChangelogUpdates'; diff --git a/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/hooks/useShowNoChangelogUpdates.ts b/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/hooks/useShowNoChangelogUpdates.ts deleted file mode 100644 index cc30f5c5ac..0000000000 --- a/desktop/packages/mullvad-vpn/src/renderer/components/views/changelog/hooks/useShowNoChangelogUpdates.ts +++ /dev/null @@ -1,9 +0,0 @@ -import { useHasChangelog } from './useHasChangelog'; - -export const useShowNoChangelogUpdates = () => { - const hasChangelog = useHasChangelog(); - - const showNoChangelogUpdates = !hasChangelog; - - return showNoChangelogUpdates; -}; |
