diff options
| author | Albin <albin@mullvad.net> | 2024-01-11 16:36:26 +0100 |
|---|---|---|
| committer | Albin <albin@mullvad.net> | 2024-01-11 16:54:01 +0100 |
| commit | 0dd07d9ecb2cfeddfe9247b723f742cd3494c1ed (patch) | |
| tree | 325f82725bc5acecdb7c2439308ffa2f5f492fd4 | |
| parent | 055e92918aa5d0ec51e6a4c89f761162f0ab9419 (diff) | |
| download | mullvadvpn-0dd07d9ecb2cfeddfe9247b723f742cd3494c1ed.tar.xz mullvadvpn-0dd07d9ecb2cfeddfe9247b723f742cd3494c1ed.zip | |
Update lint baselines
| -rw-r--r-- | android/app/lint-baseline.xml | 50 | ||||
| -rw-r--r-- | android/lib/common/build.gradle.kts | 1 | ||||
| -rw-r--r-- | android/lib/common/lint-baseline.xml | 15 | ||||
| -rw-r--r-- | android/lib/resource/lint-baseline.xml | 85 |
4 files changed, 46 insertions, 105 deletions
diff --git a/android/app/lint-baseline.xml b/android/app/lint-baseline.xml index f176afcc1c..ae420539c8 100644 --- a/android/app/lint-baseline.xml +++ b/android/app/lint-baseline.xml @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<issues format="6" by="lint 8.1.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.1.0)" variant="all" version="8.1.0"> +<issues format="6" by="lint 8.1.4" type="baseline" client="gradle" dependencies="false" name="AGP (8.1.4)" variant="all" version="8.1.4"> <issue id="MissingSuperCall" @@ -8,44 +8,11 @@ errorLine2=" ~~~~~~~~~~~~~~~~"> <location file="src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt" - line="134" + line="70" column="18"/> </issue> <issue - id="InlinedApi" - message="Field requires API level 33 (current min is 26): `android.Manifest.permission#POST_NOTIFICATIONS`" - errorLine1=" requestNotificationPermissionLauncher.launch(Manifest.permission.POST_NOTIFICATIONS)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt" - line="357" - column="58"/> - </issue> - - <issue - id="RedundantLabel" - message="Redundant label can be removed" - errorLine1=" android:label="@string/app_name"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/debug/AndroidManifest.xml" - line="21" - column="13"/> - </issue> - - <issue - id="RedundantLabel" - message="Redundant label can be removed" - errorLine1=" android:label="@string/app_name"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/AndroidManifest.xml" - line="33" - column="19"/> - </issue> - - <issue id="UseCheckPermission" message="The result of `checkPermission` is not used" errorLine1=" mockedPackageManager.checkPermission(internet, packageName)" @@ -63,7 +30,7 @@ errorLine2=" ~~~~~"> <location file="src/main/AndroidManifest.xml" - line="23" + line="25" column="39"/> </issue> @@ -78,15 +45,4 @@ column="22"/> </issue> - <issue - id="MergeRootFrame" - message="This `<FrameLayout>` can be replaced with a `<merge>` tag" - errorLine1="<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"" - errorLine2="^"> - <location - file="src/main/res/layout/main.xml" - line="1" - column="1"/> - </issue> - </issues> diff --git a/android/lib/common/build.gradle.kts b/android/lib/common/build.gradle.kts index f2fd6f104b..e327a8922c 100644 --- a/android/lib/common/build.gradle.kts +++ b/android/lib/common/build.gradle.kts @@ -19,7 +19,6 @@ android { lint { lintConfig = file("${rootProject.projectDir}/config/lint.xml") - baseline = file("lint-baseline.xml") abortOnError = true warningsAsErrors = true } diff --git a/android/lib/common/lint-baseline.xml b/android/lib/common/lint-baseline.xml deleted file mode 100644 index 141342d165..0000000000 --- a/android/lib/common/lint-baseline.xml +++ /dev/null @@ -1,15 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<issues format="6" by="lint 8.0.2" type="baseline" client="gradle" dependencies="false" name="AGP (8.0.2)" variant="all" version="8.0.2"> - - <issue - id="QueryAllPackagesPermission" - message="A `<queries>` declaration should generally be used instead of QUERY_ALL_PACKAGES; \
see https://g.co/dev/packagevisibility for details" - errorLine1=" <uses-permission android:name="android.permission.QUERY_ALL_PACKAGES" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/AndroidManifest.xml" - line="3" - column="22"/> - </issue> - -</issues> diff --git a/android/lib/resource/lint-baseline.xml b/android/lib/resource/lint-baseline.xml index 02060c3f43..13532ef7b2 100644 --- a/android/lib/resource/lint-baseline.xml +++ b/android/lib/resource/lint-baseline.xml @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<issues format="6" by="lint 8.1.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.1.0)" variant="all" version="8.1.0"> +<issues format="6" by="lint 8.1.4" type="baseline" client="gradle" dependencies="false" name="AGP (8.1.4)" variant="all" version="8.1.4"> <issue id="ImpliedQuantity" @@ -70,154 +70,154 @@ <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">il y a un jour</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">Les crédits du compte expirent dans un jour</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-fr/plurals.xml" - line="16" + line="24" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">há um dia</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">O crédito da conta expira dentro de um dia</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-pt/plurals.xml" - line="16" + line="24" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">il y a une minute</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">Les crédits du compte expirent dans une heure</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-fr/plurals.xml" - line="20" + line="28" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">há um minuto</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">O crédito da conta expira dentro de uma hora</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-pt/plurals.xml" - line="20" + line="28" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">il y a un mois</item>" + errorLine1=" <item quantity="one">il y a un jour</item>" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-fr/plurals.xml" - line="24" + line="32" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">há um mês</item>" + errorLine1=" <item quantity="one">há um dia</item>" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-pt/plurals.xml" - line="24" + line="32" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">il y a un an</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">il y a une minute</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-fr/plurals.xml" - line="28" + line="36" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">há um ano</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">há um minuto</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-pt/plurals.xml" - line="28" + line="36" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">il y a une heure</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">il y a un mois</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-fr/plurals.xml" - line="32" + line="40" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">há uma hora</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">há um mês</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-pt/plurals.xml" - line="32" + line="40" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">Les crédits du compte expirent dans un jour</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">il y a un an</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-fr/plurals.xml" - line="36" + line="44" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">O crédito da conta expira dentro de um dia</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">há um ano</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-pt/plurals.xml" - line="36" + line="44" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">Les crédits du compte expirent dans une heure</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">il y a une heure</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-fr/plurals.xml" - line="40" + line="48" column="9"/> </issue> <issue id="ImpliedQuantity" message="The quantity `'one'` matches more than one specific number in this locale (0, 1), but the message did not \
include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue \
explanation for more." - errorLine1=" <item quantity="one">O crédito da conta expira dentro de uma hora</item>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <item quantity="one">há uma hora</item>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="src/main/res/values-pt/plurals.xml" - line="40" + line="48" column="9"/> </issue> @@ -235,7 +235,8 @@ errorLine2=" ~~~~~~~~~"> <location file="src/main/res/drawable/account_history_remove_pressed.xml" - line="8"/> + line="7" + column="30"/> </issue> <issue |
