Refactor logic for when to start installer

Mainly to be easier to read.

1 files changed, 4 insertions, 4 deletions

diff --git a/desktop/packages/mullvad-vpn/src/renderer/app.tsx b/desktop/packages/mullvad-vpn/src/renderer/app.tsx
index c65541bc73..595f0c71de 100644
--- a/desktop/packages/mullvad-vpn/src/renderer/app.tsx
+++ b/desktop/packages/mullvad-vpn/src/renderer/app.tsx
@@ -416,15 +416,15 @@ export default class AppRenderer {
     const appUpgradeEvent = reduxState.appUpgrade.event;
     const appUpgradeError = reduxState.appUpgrade.error;
     const verifiedInstallerPath = reduxState.version.suggestedUpgrade?.verifiedInstallerPath;
+    const hasVerifiedInstallerPath =
+      typeof verifiedInstallerPath === 'string' && verifiedInstallerPath.length > 0;
 
     // Ensure we have a the path to the verified installer and that we are not already trying
     // to start the installer.
     if (
-      typeof verifiedInstallerPath === 'string' &&
-      verifiedInstallerPath.length > 0 &&
+      hasVerifiedInstallerPath &&
       (appUpgradeEvent?.type !== 'APP_UPGRADE_STATUS_STARTING_INSTALLER' ||
-        (appUpgradeEvent?.type === 'APP_UPGRADE_STATUS_STARTING_INSTALLER' &&
-          appUpgradeError === 'START_INSTALLER_FAILED'))
+        appUpgradeError === 'START_INSTALLER_FAILED')
     ) {
       // Ensure we don't try to start the installer multiple times by setting the status
       // as starting