summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorLinus Färnstrand <linus@mullvad.net>2025-03-18 10:20:45 +0100
committerLinus Färnstrand <linus@mullvad.net>2025-03-18 14:30:05 +0100
commit31308e7e05ea498124ec9c32c5430c44092b94c3 (patch)
tree0e506d3a614af01239b1e809541edb0843b6636a
parentd076d814866ce33353031bdf61d5db3037984d64 (diff)
downloadmullvadvpn-31308e7e05ea498124ec9c32c5430c44092b94c3.tar.xz
mullvadvpn-31308e7e05ea498124ec9c32c5430c44092b94c3.zip
Remove needsless cloning of objects
-rw-r--r--mullvad-daemon/src/version_check.rs2
-rw-r--r--mullvad-update/meta/src/platform.rs2
-rw-r--r--talpid-core/src/split_tunnel/windows/mod.rs2
-rw-r--r--talpid-dbus/src/systemd_resolved.rs3
4 files changed, 4 insertions, 5 deletions
diff --git a/mullvad-daemon/src/version_check.rs b/mullvad-daemon/src/version_check.rs
index c5da930c27..0539d675f1 100644
--- a/mullvad-daemon/src/version_check.rs
+++ b/mullvad-daemon/src/version_check.rs
@@ -405,7 +405,7 @@ impl UpdateContext {
async move {
log::debug!("Writing version check cache to {}", cache_path.display());
- let cached_app_version = CachedAppVersionInfo::from(last_app_version.to_owned());
+ let cached_app_version = CachedAppVersionInfo::from(last_app_version);
let buf = serde_json::to_vec_pretty(&cached_app_version).map_err(Error::Serialize)?;
tokio::fs::write(cache_path, buf)
.await
diff --git a/mullvad-update/meta/src/platform.rs b/mullvad-update/meta/src/platform.rs
index 4a75df736d..00a391a925 100644
--- a/mullvad-update/meta/src/platform.rs
+++ b/mullvad-update/meta/src/platform.rs
@@ -278,7 +278,7 @@ impl Platform {
let new_release = format::Release {
changelog: changes.to_owned(),
version: version.clone(),
- installers: installers.to_owned(),
+ installers,
rollout,
};
diff --git a/talpid-core/src/split_tunnel/windows/mod.rs b/talpid-core/src/split_tunnel/windows/mod.rs
index 79c0d09a5c..4e87d5f113 100644
--- a/talpid-core/src/split_tunnel/windows/mod.rs
+++ b/talpid-core/src/split_tunnel/windows/mod.rs
@@ -446,7 +446,7 @@ impl SplitTunnel {
error.display_chain_with_msg("Failed to update path monitor")
);
}
- *monitored_paths_guard = paths.to_vec();
+ *monitored_paths_guard = paths;
}
result
diff --git a/talpid-dbus/src/systemd_resolved.rs b/talpid-dbus/src/systemd_resolved.rs
index 7dad235ac7..61b045adcc 100644
--- a/talpid-dbus/src/systemd_resolved.rs
+++ b/talpid-dbus/src/systemd_resolved.rs
@@ -261,7 +261,6 @@ impl SystemdResolved {
}
pub fn set_dns(&self, interface_index: u32, servers: Vec<IpAddr>) -> Result<DnsState> {
- let set_servers = servers.to_vec();
let link_object_path = self
.fetch_link(interface_index)
.map_err(|e| Error::GetLinkError(Box::new(e)))?;
@@ -269,7 +268,7 @@ impl SystemdResolved {
Ok(DnsState {
interface_path: link_object_path,
interface_index,
- set_servers,
+ set_servers: servers,
})
}