Don't pointlessly write settings migration result to disk

1 files changed, 7 insertions, 0 deletions

diff --git a/mullvad-daemon/src/migrations/mod.rs b/mullvad-daemon/src/migrations/mod.rs
index 73dc0f857b..9a28c41266 100644
--- a/mullvad-daemon/src/migrations/mod.rs
+++ b/mullvad-daemon/src/migrations/mod.rs
@@ -108,6 +108,8 @@ pub async fn migrate_all(cache_dir: &Path, settings_dir: &Path) -> Result<()> {
         return Err(Error::NoMatchingVersion);
     }
 
+    let old_settings = settings.clone();
+
     v1::migrate(&mut settings)?;
     v2::migrate(&mut settings)?;
     v3::migrate(&mut settings)?;
@@ -117,6 +119,11 @@ pub async fn migrate_all(cache_dir: &Path, settings_dir: &Path) -> Result<()> {
     account_history::migrate_location(cache_dir, settings_dir).await;
     account_history::migrate_formats(settings_dir, &mut settings).await?;
 
+    if settings == old_settings {
+        // Nothing changed
+        return Ok(());
+    }
+
     let buffer = serde_json::to_string_pretty(&settings).map_err(Error::SerializeError)?;
 
     let mut options = fs::OpenOptions::new();