diff options
| author | anderklander <anderklander@gmail.com> | 2018-04-04 14:34:21 +0200 |
|---|---|---|
| committer | anderklander <anderklander@gmail.com> | 2018-04-11 13:45:42 +0200 |
| commit | 3ba2ea332f91bda7178ccf0a6106e92194007294 (patch) | |
| tree | 09291677a5e70eba40c209c80428f4ca35ed330f | |
| parent | cc10334d7b5c5913390de7f7c3040f9a7d0fc9bb (diff) | |
| download | mullvadvpn-3ba2ea332f91bda7178ccf0a6106e92194007294.tar.xz mullvadvpn-3ba2ea332f91bda7178ccf0a6106e92194007294.zip | |
Click area modification and style alignment
| -rw-r--r-- | app/components/SelectLocation.js | 16 | ||||
| -rw-r--r-- | app/components/SelectLocationStyles.js | 35 |
2 files changed, 36 insertions, 15 deletions
diff --git a/app/components/SelectLocation.js b/app/components/SelectLocation.js index 202034bd41..f938adbfe3 100644 --- a/app/components/SelectLocation.js +++ b/app/components/SelectLocation.js @@ -124,10 +124,12 @@ export default class SelectLocation extends React.Component<SelectLocationProps, }); } - _relayStatusIndicator(active: boolean) { + _relayStatusIndicator(active: boolean, isSelected: boolean) { const statusClass = active ? styles.relay_status__active : styles.relay_status__inactive; - return (<View style={[ styles.relay_status, statusClass ]}></View>); + return ( isSelected ? + <Img style={ styles.tick_icon } source='icon-tick' height='24' width='24' /> : + <View style={[ styles.relay_status, statusClass ]}></View>); } _renderCountry(relayCountry: RelayLocationRedux) { @@ -149,14 +151,12 @@ export default class SelectLocation extends React.Component<SelectLocationProps, <View key={ relayCountry.code } style={styles.country}> <CellButton cellHoverStyle={ isSelected ? styles.cell_selected : null } - style={ isSelected ? styles.cell_selected : null } + style={ isSelected ? styles.cell_selected : styles.cell } onPress={ handleSelect } disabled={!relayCountry.hasActiveRelays} testName='country'> - { isSelected ? - <Img style={ styles.tick_icon } source='icon-tick' height='24' width='24' /> : - this._relayStatusIndicator(relayCountry.hasActiveRelays) } + { this._relayStatusIndicator(relayCountry.hasActiveRelays, isSelected) } <Label> { relayCountry.name } @@ -200,9 +200,7 @@ export default class SelectLocation extends React.Component<SelectLocationProps, testName='city' ref={onRef}> - { isSelected ? - <Img style={ styles.tick_icon } source='icon-tick' height='24' width='24' /> : - this._relayStatusIndicator(relayCity.hasActiveRelays) } + { this._relayStatusIndicator(relayCity.hasActiveRelays, isSelected) } <Label> { relayCity.name } diff --git a/app/components/SelectLocationStyles.js b/app/components/SelectLocationStyles.js index fe5768d9f2..6137635ca7 100644 --- a/app/components/SelectLocationStyles.js +++ b/app/components/SelectLocationStyles.js @@ -31,8 +31,10 @@ export default { width: 16, height: 16, borderRadius: 8, - marginLeft: 8, - marginRight: 8, + marginLeft: 4, + marginRight: 4, + marginTop: 20, + marginBottom: 20, }, relay_status__inactive: { backgroundColor: colors.red95, @@ -41,27 +43,48 @@ export default { backgroundColor: colors.green90, }, tick_icon: { - marginLeft: 4, - marginRight: 4, + marginLeft: 0, + marginRight: 0, + marginTop: 14, + marginBottom: 14, }, country: { flexDirection: 'column', flex: 0, }, collapse_button: { - height: 24, - width: 24, + flex: 0, alignSelf: 'flex-end', + paddingTop: 14, + paddingBottom: 14, + paddingRight: 16, + paddingLeft: 16, + }, + cell: { + paddingTop: 0, + paddingBottom: 0, + paddingLeft: 24, + paddingRight: 0, }, sub_cell: { + paddingTop: 0, + paddingBottom: 0, + paddingRight: 0, paddingLeft: 40, backgroundColor: colors.blue40, }, sub_cell__selected: { + paddingTop: 0, + paddingBottom: 0, + paddingRight: 0, paddingLeft: 40, backgroundColor: colors.green, }, cell_selected: { + paddingTop: 0, + paddingBottom: 0, + paddingLeft: 20, + paddingRight: 0, backgroundColor: colors.green, }, expand_chevron_hover: { |
