diff options
| author | David Göransson <david.goransson@mullvad.net> | 2025-08-04 08:40:58 +0200 |
|---|---|---|
| committer | David Göransson <david.goransson@mullvad.net> | 2025-08-04 09:56:21 +0200 |
| commit | 48890dcc522c8fbbf0e44df5e1e87d6bd3b4b17d (patch) | |
| tree | 4fb1c411eebc567de59500d375093493a0dc2f52 | |
| parent | 716373185c2dd0fd3242546f5340d1c33158083a (diff) | |
| download | mullvadvpn-48890dcc522c8fbbf0e44df5e1e87d6bd3b4b17d.tar.xz mullvadvpn-48890dcc522c8fbbf0e44df5e1e87d6bd3b4b17d.zip | |
Add additional logging on login failure
| -rw-r--r-- | android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModel.kt | 9 | ||||
| -rw-r--r-- | android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModelTest.kt | 2 |
2 files changed, 8 insertions, 3 deletions
diff --git a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModel.kt b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModel.kt index 088b5f3ae2..32004e2852 100644 --- a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModel.kt +++ b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModel.kt @@ -2,6 +2,7 @@ package net.mullvad.mullvadvpn.viewmodel import androidx.lifecycle.ViewModel import androidx.lifecycle.viewModelScope +import co.touchlab.kermit.Logger import kotlinx.coroutines.CoroutineDispatcher import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.async @@ -168,8 +169,12 @@ class LoginViewModel( LoginAccountError.InvalidAccount -> Idle(LoginError.InvalidCredentials) is LoginAccountError.MaxDevicesReached -> Idle().also { _uiSideEffect.send(LoginUiSideEffect.TooManyDevices(accountNumber)) } - LoginAccountError.RpcError, - is LoginAccountError.Unknown -> Idle(LoginError.Unknown(this.toString())) + LoginAccountError.RpcError -> + Idle(LoginError.Unknown(this.toString())).also { Logger.w("RPC Error") } + is LoginAccountError.Unknown -> + Idle(LoginError.Unknown(this.toString())).also { + Logger.w("Login failed with error: $this", error) + } } private fun isInternetAvailable(): Boolean { diff --git a/android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModelTest.kt b/android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModelTest.kt index eeb848dc14..09a9ff8bdb 100644 --- a/android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModelTest.kt +++ b/android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/LoginViewModelTest.kt @@ -205,7 +205,7 @@ class LoginViewModelTest { loginViewModel.uiState.test { // Arrange coEvery { mockedAccountRepository.login(any()) } returns - LoginAccountError.Unknown(mockk()).left() + LoginAccountError.Unknown(Throwable()).left() // Act, Assert skipDefaultItem() |