summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorDavid Lönnhager <david.l@mullvad.net>2020-05-04 14:34:24 +0200
committerDavid Lönnhager <david.l@mullvad.net>2020-05-05 10:00:25 +0200
commit60a6989892b97e63a5bd17ac9675bf90389e6b97 (patch)
tree53b5debbae6bec9980fbdd7fa0fa61a6e31fd61a
parent9f3fe9576385ff2f2750b92fe211e8da292e5584 (diff)
downloadmullvadvpn-60a6989892b97e63a5bd17ac9675bf90389e6b97.tar.xz
mullvadvpn-60a6989892b97e63a5bd17ac9675bf90389e6b97.zip
Fix leak when the log sink constructor throws
-rw-r--r--windows/nsis-plugins/src/log/logger.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/windows/nsis-plugins/src/log/logger.cpp b/windows/nsis-plugins/src/log/logger.cpp
index 611e323282..6ce7312744 100644
--- a/windows/nsis-plugins/src/log/logger.cpp
+++ b/windows/nsis-plugins/src/log/logger.cpp
@@ -26,6 +26,7 @@ Utf8FileLogSink::Utf8FileLogSink(const std::wstring &file, bool append, bool flu
if (FALSE == seekStatus)
{
+ CloseHandle(m_logfile);
THROW_WINDOWS_ERROR(GetLastError(), "Seek to end offset in existing log file");
}
}