summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorDavid Lönnhager <david.l@mullvad.net>2024-11-20 08:35:38 +0100
committerDavid Lönnhager <david.l@mullvad.net>2024-11-22 13:38:10 +0100
commit7448ad267bcab06fed0bb3a278e5f91b9d885b81 (patch)
tree680e7f1b93a31a9be87962fc109575e074a948ca
parent3a872179b34a6fdda2660cd5f14e35f769f913a3 (diff)
downloadmullvadvpn-7448ad267bcab06fed0bb3a278e5f91b9d885b81.tar.xz
mullvadvpn-7448ad267bcab06fed0bb3a278e5f91b9d885b81.zip
Add comment about tokio runtime and getaddrinfo
-rw-r--r--mullvad-jni/src/lib.rs3
1 files changed, 3 insertions, 0 deletions
diff --git a/mullvad-jni/src/lib.rs b/mullvad-jni/src/lib.rs
index 755cfce623..1dd7c86942 100644
--- a/mullvad-jni/src/lib.rs
+++ b/mullvad-jni/src/lib.rs
@@ -122,6 +122,9 @@ pub extern "system" fn Java_net_mullvad_mullvadvpn_service_MullvadDaemon_shutdow
if let Some(context) = DAEMON_CONTEXT.lock().unwrap().take() {
_ = context.daemon_command_tx.shutdown();
_ = context.runtime.block_on(context.running_daemon);
+
+ // Dropping the tokio runtime will block if there are any tasks in flight.
+ // That is, until all async tasks yield *and* all blocking threads have stopped.
}
}