summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorDavid Lönnhager <david.l@mullvad.net>2025-03-03 16:06:37 +0100
committerDavid Lönnhager <david.l@mullvad.net>2025-03-05 23:32:48 +0100
commit838566717d3a923102a45fa9d7b581034769825b (patch)
tree3c26484982f5ee6942d4dd34f5d136d2742b8fbc
parent47ef9dea7087f8e89a840dbf70faf5b9877fe42e (diff)
downloadmullvadvpn-838566717d3a923102a45fa9d7b581034769825b.tar.xz
mullvadvpn-838566717d3a923102a45fa9d7b581034769825b.zip
Add safety comment for NSColor instantiation
-rw-r--r--installer-downloader/src/cacao_impl/ui.rs3
1 files changed, 3 insertions, 0 deletions
diff --git a/installer-downloader/src/cacao_impl/ui.rs b/installer-downloader/src/cacao_impl/ui.rs
index f65dc6ae2a..1e031761e8 100644
--- a/installer-downloader/src/cacao_impl/ui.rs
+++ b/installer-downloader/src/cacao_impl/ui.rs
@@ -42,6 +42,9 @@ static BANNER_COLOR: LazyLock<Color> = LazyLock::new(|| {
// Maybe using calibrated colors is more correct? Rendering different colors *definitely*
// is not.
let id =
+ // SAFETY: This function returns a pointer to a refcounted NSColor instance, and panics if
+ // a null pointer is passed.
+ // See https://developer.apple.com/documentation/appkit/nscolor/init(red:green:blue:alpha:)?language=objc
unsafe { Id::from_retained_ptr(msg_send![class!(NSColor), colorWithRed:r green:g blue:b alpha:a]) };
Color::Custom(Arc::new(RwLock::new(id)))
});