diff options
| author | Markus Pettersson <markus.pettersson@mullvad.net> | 2025-01-13 19:17:38 +0100 |
|---|---|---|
| committer | Markus Pettersson <markus.pettersson@mullvad.net> | 2025-01-14 09:18:59 +0100 |
| commit | 9649e07f76cde5dd0adbe8c4335fd54d35fbcaf6 (patch) | |
| tree | 0851dccab769aa86b544d0c341e75dcc8d02e5ea | |
| parent | 8dcbb3979003ab30f7f86eb8bb90eb03ba36a184 (diff) | |
| download | mullvadvpn-9649e07f76cde5dd0adbe8c4335fd54d35fbcaf6.tar.xz mullvadvpn-9649e07f76cde5dd0adbe8c4335fd54d35fbcaf6.zip | |
Fix new `clippy` warnings
| -rw-r--r-- | talpid-core/src/split_tunnel/macos/process.rs | 2 | ||||
| -rw-r--r-- | talpid-dbus/src/systemd_resolved.rs | 3 | ||||
| -rw-r--r-- | talpid-types/src/net/proxy.rs | 4 |
3 files changed, 4 insertions, 5 deletions
diff --git a/talpid-core/src/split_tunnel/macos/process.rs b/talpid-core/src/split_tunnel/macos/process.rs index 05f83b2497..7b3d644cd5 100644 --- a/talpid-core/src/split_tunnel/macos/process.rs +++ b/talpid-core/src/split_tunnel/macos/process.rs @@ -567,7 +567,7 @@ mod test { msg.contains('\n'), "Message does not contain a newline!! Make sure to add a newline to '{msg}'" ); - let (stdout_read, mut stdout_write) = simplex(msg.as_bytes().len()); + let (stdout_read, mut stdout_write) = simplex(msg.len()); // "print" to "stdout" after `duration`. tokio::spawn(async move { tokio::time::sleep(lag).await; diff --git a/talpid-dbus/src/systemd_resolved.rs b/talpid-dbus/src/systemd_resolved.rs index b678d5bf20..7dad235ac7 100644 --- a/talpid-dbus/src/systemd_resolved.rs +++ b/talpid-dbus/src/systemd_resolved.rs @@ -208,8 +208,7 @@ impl SystemdResolved { let parts = contents.trim().split(' '); parts .map(str::parse::<IpAddr>) - .map(|maybe_ip| maybe_ip.map(|addr| addr.is_loopback()).unwrap_or(false)) - .any(|is_loopback| is_loopback) + .any(|maybe_ip| maybe_ip.map(|addr| addr.is_loopback()).unwrap_or(false)) }) .unwrap_or(false); diff --git a/talpid-types/src/net/proxy.rs b/talpid-types/src/net/proxy.rs index d60b2df436..c73db5a355 100644 --- a/talpid-types/src/net/proxy.rs +++ b/talpid-types/src/net/proxy.rs @@ -159,12 +159,12 @@ impl SocksAuth { /// assert!(too_long_username.is_err()); /// ``` pub fn new(username: String, password: String) -> Result<Self, Error> { - if !(1..=255).contains(&password.as_bytes().len()) { + if !(1..=255).contains(&password.len()) { return Err(Error::InvalidSocksAuthValues( "Password length should between 1 and 255 bytes", )); } - if !(1..=255).contains(&username.as_bytes().len()) { + if !(1..=255).contains(&username.len()) { return Err(Error::InvalidSocksAuthValues( "Username length should between 1 and 255 bytes", )); |
