diff options
| author | Tobias Järvelöv <tobias.jarvelov@mullvad.net> | 2025-09-03 08:15:57 +0200 |
|---|---|---|
| committer | Tobias Järvelöv <tobias.jarvelov@mullvad.net> | 2025-09-30 09:51:49 +0200 |
| commit | 9bd09c08de701732b212be4d7d85edb51883a3e8 (patch) | |
| tree | 4d67320f9cc9d5fb2eec2a1c055539d11c4689e7 | |
| parent | 51330c293c505af286246aef47d2f06bf08612b9 (diff) | |
| download | mullvadvpn-9bd09c08de701732b212be4d7d85edb51883a3e8.tar.xz mullvadvpn-9bd09c08de701732b212be4d7d85edb51883a3e8.zip | |
Refactor ProxyFormButton to use context in favor of props
| -rw-r--r-- | desktop/packages/mullvad-vpn/src/renderer/components/ProxyForm.tsx | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/desktop/packages/mullvad-vpn/src/renderer/components/ProxyForm.tsx b/desktop/packages/mullvad-vpn/src/renderer/components/ProxyForm.tsx index cdf8cdddf0..b687201f45 100644 --- a/desktop/packages/mullvad-vpn/src/renderer/components/ProxyForm.tsx +++ b/desktop/packages/mullvad-vpn/src/renderer/components/ProxyForm.tsx @@ -78,7 +78,7 @@ export function ProxyForm(props: ProxyFormContextProviderProps) { <ProxyFormContextProvider {...props}> <SettingsForm> <ProxyFormInner /> - <ProxyFormButtons new={props.proxy === undefined} /> + <ProxyFormButtons /> </SettingsForm> </ProxyFormContextProvider> ); @@ -126,7 +126,7 @@ export function NamedProxyForm(props: NamedProxyFormContainerProps) { <SettingsForm> <ProxyFormNameField /> <ProxyFormInner /> - <ProxyFormButtons new={props.proxy === undefined} /> + <ProxyFormButtons /> </SettingsForm> </ProxyFormContextProvider> </namedProxyFormContext.Provider> @@ -149,12 +149,8 @@ function ProxyFormNameField() { ); } -interface ProxyFormButtonsProps { - new: boolean; -} - -export function ProxyFormButtons(props: ProxyFormButtonsProps) { - const { onSave, onCancel, onDelete } = useContext(proxyFormContext); +export function ProxyFormButtons() { + const { onSave, onCancel, onDelete, proxy } = useContext(proxyFormContext); // Contains form submittability to know whether or not to enable the Add/Save button. const formSubmittable = useSettingsFormSubmittable(); @@ -172,9 +168,7 @@ export function ProxyFormButtons(props: ProxyFormButtonsProps) { <Button.Text>{messages.gettext('Cancel')}</Button.Text> </Button> <Button onClick={onSave} disabled={!formSubmittable}> - <Button.Text> - {props.new ? messages.gettext('Add') : messages.gettext('Save')} - </Button.Text> + <Button.Text>{proxy ? messages.gettext('Save') : messages.gettext('Add')}</Button.Text> </Button> </FlexRow> </Flex> |
