diff options
| author | Oliver <oliver@mohlin.dev> | 2025-10-07 12:05:58 +0200 |
|---|---|---|
| committer | Tobias Järvelöv <tobias.jarvelov@mullvad.net> | 2025-10-10 13:38:06 +0200 |
| commit | a43bda97b0d6329310399d2604eb05a47a4e7833 (patch) | |
| tree | c6502b635df172483ff062f1a0f683417567115c | |
| parent | 33373e0b62eafbe4201dcc387f02975e7d976e2b (diff) | |
| download | mullvadvpn-a43bda97b0d6329310399d2604eb05a47a4e7833.tar.xz mullvadvpn-a43bda97b0d6329310399d2604eb05a47a4e7833.zip | |
Remove no-op catch blocks when fetching devices
2 files changed, 7 insertions, 13 deletions
diff --git a/desktop/packages/mullvad-vpn/src/renderer/components/device-list-item/components/confirm-dialog/hooks/use-handle-remove-device-error.ts b/desktop/packages/mullvad-vpn/src/renderer/components/device-list-item/components/confirm-dialog/hooks/use-handle-remove-device-error.ts index af2d93ceec..ed9fab49ff 100644 --- a/desktop/packages/mullvad-vpn/src/renderer/components/device-list-item/components/confirm-dialog/hooks/use-handle-remove-device-error.ts +++ b/desktop/packages/mullvad-vpn/src/renderer/components/device-list-item/components/confirm-dialog/hooks/use-handle-remove-device-error.ts @@ -23,14 +23,12 @@ export const useHandleRemoveDeviceError = () => { let devices: Array<IDevice> | undefined = undefined; try { devices = await fetchDevices(accountNumber); - } catch { - /* no-op */ - } - - if (devices === undefined || devices.some((device) => device.id === deviceId)) { - hideConfirmDialog(); - resetDeleting(); - setError(); + } finally { + if (devices === undefined || devices.some((device) => device.id === deviceId)) { + hideConfirmDialog(); + resetDeleting(); + setError(); + } } }, [fetchDevices, accountNumber, deviceId, hideConfirmDialog, resetDeleting, setError], diff --git a/desktop/packages/mullvad-vpn/src/renderer/components/device-list/hooks/use-get-devices.ts b/desktop/packages/mullvad-vpn/src/renderer/components/device-list/hooks/use-get-devices.ts index c4bed93361..b48b458775 100644 --- a/desktop/packages/mullvad-vpn/src/renderer/components/device-list/hooks/use-get-devices.ts +++ b/desktop/packages/mullvad-vpn/src/renderer/components/device-list/hooks/use-get-devices.ts @@ -10,11 +10,7 @@ export const useGetDevices = () => { const devices = useSortedDevices(); React.useEffect(() => { - try { - void fetchDevices(accountNumber); - } catch { - /* no-op */ - } + void fetchDevices(accountNumber); }, [accountNumber, fetchDevices]); return devices; |
