summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorJonatan Rhodin <jonatan.rhodin@mullvad.net>2023-08-31 15:14:17 +0200
committerJonatan Rhodin <jonatan.rhodin@mullvad.net>2023-09-01 07:57:22 +0200
commita7a5fdbf63129b01de8ce4094954742db14fac33 (patch)
treeac478ddb06ebdfe6c57db9bc9014476c3acaaf53
parent2bbf2d666812da5dec8bc01822b0593279ee0884 (diff)
downloadmullvadvpn-a7a5fdbf63129b01de8ce4094954742db14fac33.tar.xz
mullvadvpn-a7a5fdbf63129b01de8ce4094954742db14fac33.zip
Fix number format crash in custom port dialog
-rw-r--r--android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/CustomPortDialog.kt9
1 files changed, 6 insertions, 3 deletions
diff --git a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/CustomPortDialog.kt b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/CustomPortDialog.kt
index c2298783d8..1d42503d1c 100644
--- a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/CustomPortDialog.kt
+++ b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/CustomPortDialog.kt
@@ -12,10 +12,12 @@ import androidx.compose.runtime.Composable
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.ui.Modifier
+import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview
import net.mullvad.mullvadvpn.R
import net.mullvad.mullvadvpn.compose.button.ActionButton
+import net.mullvad.mullvadvpn.compose.test.CUSTOM_PORT_DIALOG_INPUT_TEST_TAG
import net.mullvad.mullvadvpn.compose.textfield.CustomPortTextField
import net.mullvad.mullvadvpn.lib.theme.AlphaDescription
import net.mullvad.mullvadvpn.lib.theme.AlphaDisabled
@@ -75,7 +77,7 @@ fun CustomPortDialog(
),
isEnabled =
port.value.isNotEmpty() &&
- allowedPortRanges.isPortInValidRanges(port.value.toInt())
+ allowedPortRanges.isPortInValidRanges(port.value.toIntOrNull() ?: 0)
)
if (showReset) {
ActionButton(
@@ -108,7 +110,7 @@ fun CustomPortDialog(
onSubmit = { input ->
if (
input.isNotEmpty() &&
- allowedPortRanges.isPortInValidRanges(input.toInt())
+ allowedPortRanges.isPortInValidRanges(input.toIntOrNull() ?: 0)
) {
onSave(input)
}
@@ -116,7 +118,8 @@ fun CustomPortDialog(
onValueChanged = { input -> port.value = input },
isValidValue =
port.value.isNotEmpty() &&
- allowedPortRanges.isPortInValidRanges(port.value.toInt())
+ allowedPortRanges.isPortInValidRanges(port.value.toIntOrNull() ?: 0),
+ modifier = Modifier.testTag(CUSTOM_PORT_DIALOG_INPUT_TEST_TAG)
)
Spacer(modifier = Modifier.height(Dimens.smallPadding))
Text(