summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorMarkus Pettersson <markus.pettersson@mullvad.net>2025-09-12 20:52:59 +0200
committerMarkus Pettersson <markus.pettersson@mullvad.net>2025-09-17 12:58:13 +0200
commitc9baf1ed9f051fcd3e70050d7539bcf199426e0d (patch)
tree39af70d05324434a5059829b213adb1b6f762ebc
parent1da2fcc8dfc40efd868aac3f61fdaeeb6d5b8c37 (diff)
downloadmullvadvpn-c9baf1ed9f051fcd3e70050d7539bcf199426e0d.tar.xz
mullvadvpn-c9baf1ed9f051fcd3e70050d7539bcf199426e0d.zip
Add note about simplifying code if upstream PR is accepted
Signed-off-by: Markus Pettersson <markus.pettersson@mullvad.net>
-rw-r--r--talpid-routing/src/unix/linux.rs6
1 files changed, 4 insertions, 2 deletions
diff --git a/talpid-routing/src/unix/linux.rs b/talpid-routing/src/unix/linux.rs
index e1f23a7ecc..14a195d977 100644
--- a/talpid-routing/src/unix/linux.rs
+++ b/talpid-routing/src/unix/linux.rs
@@ -700,7 +700,8 @@ impl RouteManagerImpl {
// Set route MTU
if let Some(mtu) = route.mtu {
- // TODO: Submit PR upstream for doing this on the builder instead.
+ // TODO: This can be done before calling `add_message.build()` if
+ // https://github.com/rust-netlink/rtnetlink/pull/126 is merged & released.
let mtu = RouteMetric::Mtu(mtu);
msg.attributes.push(RouteAttribute::Metrics(vec![mtu]));
}
@@ -872,7 +873,8 @@ impl RouteManagerImpl {
let mut request = builder.build();
if let Some(mark) = fwmark {
- // TODO: Upstream setting fwmark directly on the builder
+ // TODO: This can be done before calling `builder.build()` if
+ // https://github.com/rust-netlink/rtnetlink/pull/127 is merged & released.
let fwmark = RouteAttribute::Mark(mark);
request.attributes.push(fwmark);
}