diff options
| author | Janito Vaqueiro Ferreira Filho <janito@mullvad.net> | 2021-04-13 22:24:57 +0000 |
|---|---|---|
| committer | Janito Vaqueiro Ferreira Filho <janito@mullvad.net> | 2021-04-14 13:18:57 +0000 |
| commit | f477f25f31ca06791ea5236be00877ee8018bb97 (patch) | |
| tree | ab973ff528f9377cd82b5d0ee8f2880e185449db | |
| parent | 130f56e4b4530d096403250f675ec42031ca64f2 (diff) | |
| download | mullvadvpn-f477f25f31ca06791ea5236be00877ee8018bb97.tar.xz mullvadvpn-f477f25f31ca06791ea5236be00877ee8018bb97.zip | |
Fix return value of `CustomDns.addServer` method
The UI side method returns a boolean flag indicating if the DNS server
was successfully added, which is basically a check if the DNS server
address wasn't already added to the list. Unfortunately, there was a bug
in the method that returned the negated value. This led to a weird bug
where adding a new DNS server caused it to fail first, but succeed on
the second attempt.
| -rw-r--r-- | android/src/main/kotlin/net/mullvad/mullvadvpn/ui/serviceconnection/CustomDns.kt | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/serviceconnection/CustomDns.kt b/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/serviceconnection/CustomDns.kt index 140d1135cd..05df45955f 100644 --- a/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/serviceconnection/CustomDns.kt +++ b/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/serviceconnection/CustomDns.kt @@ -29,11 +29,11 @@ class CustomDns(val connection: Messenger, val settingsListener: SettingsListene } fun addDnsServer(server: InetAddress): Boolean { - val alreadyHadServer = onDnsServersChanged.latestEvent.contains(server) + val didntAlreadyHaveServer = !onDnsServersChanged.latestEvent.contains(server) connection.send(Request.AddCustomDnsServer(server).message) - return alreadyHadServer + return didntAlreadyHaveServer } fun replaceDnsServer(oldServer: InetAddress, newServer: InetAddress): Boolean { |