summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorMarkus Pettersson <markus.pettersson@mullvad.net>2025-10-16 21:13:30 +0200
committerMarkus Pettersson <markus.pettersson@mullvad.net>2025-10-20 17:07:03 +0200
commitf6b0fe1a9548a5e981502f0ab97b54cf08cd54db (patch)
tree59b96f3795594b469fba10c7e089f30af0263f61
parent45e12d2d948a805f563cfd7d84e52cbfa31fff53 (diff)
downloadmullvadvpn-f6b0fe1a9548a5e981502f0ab97b54cf08cd54db.tar.xz
mullvadvpn-f6b0fe1a9548a5e981502f0ab97b54cf08cd54db.zip
Improve safety comments
-rw-r--r--mullvad-paths/src/windows.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/mullvad-paths/src/windows.rs b/mullvad-paths/src/windows.rs
index ae58891e3e..e300f66877 100644
--- a/mullvad-paths/src/windows.rs
+++ b/mullvad-paths/src/windows.rs
@@ -388,14 +388,14 @@ fn get_current_thread_token() -> std::io::Result<OwnedHandle> {
}
fn impersonate_self<T>(func: impl FnOnce() -> io::Result<T>) -> io::Result<T> {
- // SAFETY: Trivially safe
+ // SAFETY: SecurityImpersonation is a valid ImpersonationLevel.
if unsafe { ImpersonateSelf(SecurityImpersonation) } == 0 {
return Err(std::io::Error::last_os_error());
}
let result = func();
- // SAFETY: Trivially safe
+ // SAFETY: Must be called after a successful call to ImpersonateSelf.
if unsafe { RevertToSelf() } == 0 {
log::error!("RevertToSelf failed: {}", io::Error::last_os_error());
}