diff options
| author | Daneo Van Overloop <daneo.van.overloop@mullvad.net> | 2026-04-20 15:18:35 +0200 |
|---|---|---|
| committer | Daneo Van Overloop <daneo.van.overloop@mullvad.net> | 2026-04-21 09:46:53 +0200 |
| commit | ebf5a0fe846aaf431a1dea2b8c4c1f25fb4c3244 (patch) | |
| tree | 9c3168b39e4160c444fe4fce3e6d54433ab8853f | |
| parent | 2a608f18e0c2caa7668535464c731e65f1e9cfc2 (diff) | |
| download | mullvadvpn-ebf5a0fe846aaf431a1dea2b8c4c1f25fb4c3244.tar.xz mullvadvpn-ebf5a0fe846aaf431a1dea2b8c4c1f25fb4c3244.zip | |
Remove duplicate iOS E2E tests-notifications
After testing and observing, we'll now use the `workflow_run` method
of observing a workflow's result to trigger failure notifications
when needed.
**Impact**: Right now we receive a **duplicate** notification if the
nightly run fails due to failing tests (as described in
9d89d7316104b2cbd158f78d94bdf824d2274d69). Removing this delegates
the notification responsibility entirely to the
`ios-end-to-end-nightly-monitor`-workflow, which also offers
observability when the run is cancelled, amongst [other][1] possible
reasons.
[1]: https://archive.is/4IM5j#check-statuses-and-conclusions
| -rw-r--r-- | .github/workflows/ios-end-to-end-tests-nightly.yml | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/.github/workflows/ios-end-to-end-tests-nightly.yml b/.github/workflows/ios-end-to-end-tests-nightly.yml index eba7d931de..fb027c5649 100644 --- a/.github/workflows/ios-end-to-end-tests-nightly.yml +++ b/.github/workflows/ios-end-to-end-tests-nightly.yml @@ -22,18 +22,3 @@ jobs: with: arg_tests_json_key: "nightly" secrets: inherit - - notify-on-failure: - if: failure() - name: Notify team on nightly E2E failure - runs-on: [self-hosted, macOS, ios-test] - needs: reuse-e2e-workflow - timeout-minutes: 5 - steps: - - name: Send custom event details to a Slack workflow - uses: slackapi/slack-github-action@v2.1.1 - with: - webhook: ${{ secrets.IOS_SLACK_WEBHOOK_URL }} - webhook-type: webhook-trigger - payload: | - run_url: "https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" |