diff options
| author | Jon Petersson <jon.petersson@mullvad.net> | 2026-04-21 11:25:52 +0200 |
|---|---|---|
| committer | Jon Petersson <jon.petersson@mullvad.net> | 2026-04-21 11:25:52 +0200 |
| commit | 574b6a6e0345e74ba170ae4aabeb4e321a9b2ad4 (patch) | |
| tree | 7ae07abcb7f08e9737eaee4f3f87878f6ccfbda3 | |
| parent | 2a608f18e0c2caa7668535464c731e65f1e9cfc2 (diff) | |
| parent | a95fb528c1b1195b9a43b64704297849dd5878cf (diff) | |
| download | mullvadvpn-574b6a6e0345e74ba170ae4aabeb4e321a9b2ad4.tar.xz mullvadvpn-574b6a6e0345e74ba170ae4aabeb4e321a9b2ad4.zip | |
Merge branch 'notify-app-ios-on-successful-nightly-test-runs-ios-1575'
| -rw-r--r-- | .github/workflows/ios-end-to-end-tests-nightly-notification.yml | 5 | ||||
| -rw-r--r-- | .github/workflows/ios-end-to-end-tests-nightly.yml | 15 |
2 files changed, 4 insertions, 16 deletions
diff --git a/.github/workflows/ios-end-to-end-tests-nightly-notification.yml b/.github/workflows/ios-end-to-end-tests-nightly-notification.yml index d7fbb7b489..7829b60b1f 100644 --- a/.github/workflows/ios-end-to-end-tests-nightly-notification.yml +++ b/.github/workflows/ios-end-to-end-tests-nightly-notification.yml @@ -13,7 +13,10 @@ jobs: notify-on-failed-workflow: # Payload of workflow_run: # https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2026-03-10#get-a-workflow-run - if: "${{ github.event.workflow_run.conclusion != 'successful' }}" + # + # Valid values for conclusion are listed on: + # https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks#check-statuses-and-conclusions + if: "${{ github.event.workflow_run.conclusion != 'success' }}" name: Notify team on nightly E2E failure runs-on: [ubuntu-latest] timeout-minutes: 5 diff --git a/.github/workflows/ios-end-to-end-tests-nightly.yml b/.github/workflows/ios-end-to-end-tests-nightly.yml index eba7d931de..fb027c5649 100644 --- a/.github/workflows/ios-end-to-end-tests-nightly.yml +++ b/.github/workflows/ios-end-to-end-tests-nightly.yml @@ -22,18 +22,3 @@ jobs: with: arg_tests_json_key: "nightly" secrets: inherit - - notify-on-failure: - if: failure() - name: Notify team on nightly E2E failure - runs-on: [self-hosted, macOS, ios-test] - needs: reuse-e2e-workflow - timeout-minutes: 5 - steps: - - name: Send custom event details to a Slack workflow - uses: slackapi/slack-github-action@v2.1.1 - with: - webhook: ${{ secrets.IOS_SLACK_WEBHOOK_URL }} - webhook-type: webhook-trigger - payload: | - run_url: "https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" |