summaryrefslogtreecommitdiffhomepage
path: root/android/app/src
diff options
context:
space:
mode:
authorAlbin <albin@mullvad.net>2023-09-29 17:34:28 +0200
committerAlbin <albin@mullvad.net>2023-10-02 11:44:51 +0200
commit0016716c66231297619cb3cea9ed59745ded82b7 (patch)
tree741b2a0100aaf8b13efb58de9e0c9a88fc3b1cd9 /android/app/src
parentb10b2ba2c5d99d70befe1c7db8e5dee444ed7e0a (diff)
downloadmullvadvpn-0016716c66231297619cb3cea9ed59745ded82b7.tar.xz
mullvadvpn-0016716c66231297619cb3cea9ed59745ded82b7.zip
Align changelog ui state property name
Diffstat (limited to 'android/app/src')
-rw-r--r--android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/ChangelogDialogTest.kt2
-rw-r--r--android/app/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt2
-rw-r--r--android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModel.kt9
-rw-r--r--android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModelTest.kt8
4 files changed, 9 insertions, 12 deletions
diff --git a/android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/ChangelogDialogTest.kt b/android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/ChangelogDialogTest.kt
index 791eb1f0c5..778799c589 100644
--- a/android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/ChangelogDialogTest.kt
+++ b/android/app/src/androidTest/kotlin/net/mullvad/mullvadvpn/compose/screen/ChangelogDialogTest.kt
@@ -31,7 +31,7 @@ class ChangelogDialogTest {
@Test
fun testShowChangeLogWhenNeeded() {
// Arrange
- every { mockedViewModel.changelogDialogUiState } returns
+ every { mockedViewModel.uiState } returns
MutableStateFlow(ChangelogDialogUiState.Show(listOf(CHANGELOG_ITEM)))
every { mockedViewModel.dismissChangelogDialog() } just Runs
diff --git a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt
index e8343aba8a..fa88696cd9 100644
--- a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt
+++ b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt
@@ -253,7 +253,7 @@ open class MainActivity : FragmentActivity() {
findViewById<ComposeView>(R.id.compose_view).apply {
setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnDetachedFromWindow)
setContent {
- val state = changelogViewModel.changelogDialogUiState.collectAsState().value
+ val state = changelogViewModel.uiState.collectAsState().value
if (state is ChangelogDialogUiState.Show) {
AppTheme {
ChangelogDialog(
diff --git a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModel.kt b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModel.kt
index 1c541944d2..f6549cded6 100644
--- a/android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModel.kt
+++ b/android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModel.kt
@@ -10,15 +10,14 @@ class ChangelogViewModel(
private val buildVersionCode: Int,
private val alwaysShowChangelog: Boolean
) : ViewModel() {
- private val _changelogDialogUiState =
- MutableStateFlow<ChangelogDialogUiState>(ChangelogDialogUiState.Hide)
- val changelogDialogUiState = _changelogDialogUiState.asStateFlow()
+ private val _uiState = MutableStateFlow<ChangelogDialogUiState>(ChangelogDialogUiState.Hide)
+ val uiState = _uiState.asStateFlow()
fun refreshChangelogDialogUiState() {
val shouldShowChangelogDialog =
alwaysShowChangelog ||
changelogRepository.getVersionCodeOfMostRecentChangelogShowed() < buildVersionCode
- _changelogDialogUiState.value =
+ _uiState.value =
if (shouldShowChangelogDialog) {
val changelogList = changelogRepository.getLastVersionChanges()
if (changelogList.isNotEmpty()) {
@@ -33,7 +32,7 @@ class ChangelogViewModel(
fun dismissChangelogDialog() {
changelogRepository.setVersionCodeOfMostRecentChangelogShowed(buildVersionCode)
- _changelogDialogUiState.value = ChangelogDialogUiState.Hide
+ _uiState.value = ChangelogDialogUiState.Hide
}
}
diff --git a/android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModelTest.kt b/android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModelTest.kt
index 3547b92065..7c74e96a75 100644
--- a/android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModelTest.kt
+++ b/android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModelTest.kt
@@ -40,14 +40,12 @@ class ChangelogViewModelTest {
@Test
fun testInitialState() = runBlockingTest {
// Arrange, Act, Assert
- viewModel.changelogDialogUiState.test {
- Assert.assertEquals(ChangelogDialogUiState.Hide, awaitItem())
- }
+ viewModel.uiState.test { Assert.assertEquals(ChangelogDialogUiState.Hide, awaitItem()) }
}
@Test
fun testShowAndDismissChangelogDialog() = runBlockingTest {
- viewModel.changelogDialogUiState.test {
+ viewModel.uiState.test {
// Arrange
val fakeList = listOf("test")
every { mockedChangelogRepository.getVersionCodeOfMostRecentChangelogShowed() } returns
@@ -70,7 +68,7 @@ class ChangelogViewModelTest {
@Test
fun testShowCaseChangelogWithEmptyListDialog() = runBlockingTest {
- viewModel.changelogDialogUiState.test {
+ viewModel.uiState.test {
// Arrange
val fakeEmptyList = emptyList<String>()
every { mockedChangelogRepository.getVersionCodeOfMostRecentChangelogShowed() } returns