summaryrefslogtreecommitdiffhomepage
path: root/android/src/main
diff options
context:
space:
mode:
authorJanito Vaqueiro Ferreira Filho <janito@mullvad.net>2020-11-20 19:08:20 +0000
committerJanito Vaqueiro Ferreira Filho <janito@mullvad.net>2020-11-20 19:14:04 +0000
commitcb43f08e32cf52aef72032bfebba20ddcd55481c (patch)
treeffc9bf0f586e3b86d95b1f61a3c6d9af84c94b9c /android/src/main
parent75f82360efa77bda5ca33dd86d4e29406948a6fb (diff)
downloadmullvadvpn-cb43f08e32cf52aef72032bfebba20ddcd55481c.tar.xz
mullvadvpn-cb43f08e32cf52aef72032bfebba20ddcd55481c.zip
Remove incorrect `LocalBinder.setUiVisible` usage
It was being called inside `MainActivity.onStart`, if the `service` property was not `null`. However, that meant it called a previous instance of the `MullvadVpnService.LocalBinder` if the service is stopped while the UI was not visible, since the activity unbinds from the service in the `onStop` method.
Diffstat (limited to 'android/src/main')
-rw-r--r--android/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt1
1 files changed, 0 insertions, 1 deletions
diff --git a/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt b/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt
index 30b209dc3e..0128df069a 100644
--- a/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt
+++ b/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/MainActivity.kt
@@ -113,7 +113,6 @@ class MainActivity : FragmentActivity() {
}
bindService(intent, serviceConnectionManager, 0)
- service?.isUiVisible = true
}
override fun onActivityResult(requestCode: Int, resultCode: Int, resultData: Intent?) {