diff options
| author | Janito Vaqueiro Ferreira Filho <janito@mullvad.net> | 2020-01-14 12:15:38 +0000 |
|---|---|---|
| committer | Janito Vaqueiro Ferreira Filho <janito@mullvad.net> | 2020-01-14 12:56:15 +0000 |
| commit | 539c177d59b39af26f488f911d3d37ed27d0ae49 (patch) | |
| tree | 87686e83f51ffbcbeff4067a2d84e0afe73e1d3b /android/src | |
| parent | 723c8d03109f36f11c1799825cf4bf42c10a3d8b (diff) | |
| download | mullvadvpn-539c177d59b39af26f488f911d3d37ed27d0ae49.tar.xz mullvadvpn-539c177d59b39af26f488f911d3d37ed27d0ae49.zip | |
Document assumption in `onNewServiceConnection`
Diffstat (limited to 'android/src')
| -rw-r--r-- | android/src/main/kotlin/net/mullvad/mullvadvpn/ui/ServiceDependentFragment.kt | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/ServiceDependentFragment.kt b/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/ServiceDependentFragment.kt index 6e39393d0f..1bafd1beeb 100644 --- a/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/ServiceDependentFragment.kt +++ b/android/src/main/kotlin/net/mullvad/mullvadvpn/ui/ServiceDependentFragment.kt @@ -62,6 +62,8 @@ abstract class ServiceDependentFragment(val onNoService: OnNoService) : ServiceA private set override fun onNewServiceConnection(serviceConnection: ServiceConnection) { + // This method is always either called first or after an `onNoServiceConnection`, so the + // initialization of the fields doesn't have to be synchronized accountCache = serviceConnection.accountCache appVersionInfoCache = serviceConnection.appVersionInfoCache connectionProxy = serviceConnection.connectionProxy |