diff options
| author | Albin <albin@mullvad.net> | 2023-09-29 19:31:53 +0200 |
|---|---|---|
| committer | Albin <albin@mullvad.net> | 2023-10-02 11:44:56 +0200 |
| commit | 8af8d3c266c032ebb1f7019fa92aec02df9053b8 (patch) | |
| tree | e4e42ff06eea92a1d7cd1972f7d4877c91de3c7e /android/test/arch | |
| parent | cc230f6a6d605b4a5caa4451e88d8f9adaac9837 (diff) | |
| download | mullvadvpn-8af8d3c266c032ebb1f7019fa92aec02df9053b8.tar.xz mullvadvpn-8af8d3c266c032ebb1f7019fa92aec02df9053b8.zip | |
Suppress konsist TODOs
Diffstat (limited to 'android/test/arch')
| -rw-r--r-- | android/test/arch/src/test/kotlin/net/mullvad/mullvadvpn/test/arch/ViewModelTests.kt | 18 |
1 files changed, 3 insertions, 15 deletions
diff --git a/android/test/arch/src/test/kotlin/net/mullvad/mullvadvpn/test/arch/ViewModelTests.kt b/android/test/arch/src/test/kotlin/net/mullvad/mullvadvpn/test/arch/ViewModelTests.kt index 47736e9611..8347c799d7 100644 --- a/android/test/arch/src/test/kotlin/net/mullvad/mullvadvpn/test/arch/ViewModelTests.kt +++ b/android/test/arch/src/test/kotlin/net/mullvad/mullvadvpn/test/arch/ViewModelTests.kt @@ -20,8 +20,9 @@ class ViewModelTests { // properties that shouldn't be exposed. @Test fun ensurePublicPropertiesUsePermittedNames() { - allViewModels().properties().withPublicOrDefaultModifier().assert { property -> - permittedPublicPropertyNames.contains(property.name) + allViewModels().properties(includeNested = false).withPublicOrDefaultModifier().assert { + property -> + property.name == "uiState" || property.name == "uiSideEffect" } } @@ -34,17 +35,4 @@ class ViewModelTests { private fun allViewModels() = Konsist.scopeFromProject().classes().withAllParentsOf(ViewModel::class) - - companion object { - // TODO: The goal is to reduce this list to only "uiState" and "uiSideEffect". - private val permittedPublicPropertyNames = - listOf( - "uiState", - "uiSideEffect", - "toastMessages", - "uiCloseAction", - "enterTransitionEndAction", - "accountToken" - ) - } } |
