Add test for naming of declarations and parameters

1 files changed, 33 insertions, 0 deletions

diff --git a/android/test/arch/src/test/kotlin/net/mullvad/mullvadvpn/test/arch/NameTest.kt b/android/test/arch/src/test/kotlin/net/mullvad/mullvadvpn/test/arch/NameTest.kt
new file mode 100644
index 0000000000..be397e6582
--- /dev/null
+++ b/android/test/arch/src/test/kotlin/net/mullvad/mullvadvpn/test/arch/NameTest.kt
@@ -0,0 +1,33 @@
+package net.mullvad.mullvadvpn.test.arch
+
+import com.lemonappdev.konsist.api.Konsist
+import com.lemonappdev.konsist.api.ext.list.parameters
+import com.lemonappdev.konsist.api.provider.KoNameProvider
+import com.lemonappdev.konsist.api.verify.assertFalse
+import java.util.stream.Stream
+import org.junit.jupiter.api.DynamicTest
+import org.junit.jupiter.api.DynamicTest.dynamicTest
+import org.junit.jupiter.api.TestFactory
+
+class NameTest {
+    @TestFactory
+    fun `ensure no disallowed declaration or parameter names`(): Stream<DynamicTest> =
+        DISALLOWED_DECLARATION_OR_PARAMETER_NAMES.stream().map { disallowedName ->
+            val testName = "ensure no declarations or parameters include: $disallowedName"
+            dynamicTest(testName) {
+                Konsist.scopeFromProject()
+                    .let { it.declarations() + it.functions().parameters }
+                    .filterIsInstance<KoNameProvider>()
+                    .assertFalse(testName = testName) { it.hasNameContaining(disallowedName) }
+            }
+        }
+
+    companion object {
+        private val DISALLOWED_DECLARATION_OR_PARAMETER_NAMES =
+            listOf(
+                "accountToken",
+                "AccountToken",
+                "ACCOUNT_TOKEN",
+            )
+    }
+}