Prevent duplicate string values in Android xml

2 files changed, 29 insertions, 0 deletions

diff --git a/android/translations-converter/Cargo.toml b/android/translations-converter/Cargo.toml
index 67704daf2c..3cb9176496 100644
--- a/android/translations-converter/Cargo.toml
+++ b/android/translations-converter/Cargo.toml
@@ -16,3 +16,4 @@ htmlize = { version = "1.0.2", features = ["unescape"] }
 regex = "1"
 serde = { workspace = true, features = ["derive"] }
 quick-xml = { version = "0.27.1", features = ["serialize"] }
+itertools = "0.14.0"
diff --git a/android/translations-converter/src/main.rs b/android/translations-converter/src/main.rs
index da5b6e3a27..314bbf3e44 100644
--- a/android/translations-converter/src/main.rs
+++ b/android/translations-converter/src/main.rs
@@ -35,8 +35,10 @@ mod android;
 mod gettext;
 mod normalize;
 
+use crate::android::{StringResource, StringValue};
 use crate::gettext::MsgValue;
 use crate::normalize::Normalize;
+use itertools::Itertools;
 use std::{
     collections::HashMap,
     fs::{self, File},
@@ -53,6 +55,32 @@ fn main() {
         quick_xml::de::from_reader(BufReader::new(strings_file))
             .expect("Failed to read string resources file");
 
+    // The current format is not built to handle multiple strings with the same values
+    // so we check for duplicates and panic if they are present
+    let duplicates: HashMap<&StringValue, Vec<&StringResource>> = string_resources
+        .iter()
+        .into_group_map_by(|res| &res.value)
+        .into_iter()
+        .filter(|(_, string_resources)| string_resources.len() > 1)
+        .collect();
+
+    if !duplicates.is_empty() {
+        duplicates
+            .iter()
+            .for_each(|(string_value, string_resources)| {
+                eprintln!(
+                    "String value: '{}', exists in following resource IDs: {}",
+                    string_value,
+                    string_resources
+                        .iter()
+                        .map(|x| x.name.clone())
+                        .collect::<Vec<_>>()
+                        .join(", ")
+                )
+            });
+        panic!("Duplicate string values!!");
+    }
+
     let known_strings: HashMap<_, _> = string_resources
         .into_iter()
         .map(|resource| (resource.value.normalize(), resource.name))