diff options
| author | Albin <albin@mullvad.net> | 2023-07-21 09:54:09 +0200 |
|---|---|---|
| committer | Albin <albin@mullvad.net> | 2023-07-21 16:17:59 +0200 |
| commit | 4ef5633fca6e22c6059ef9bc3cf704ad0cb7bd40 (patch) | |
| tree | b6a6d302f8e4b090405c00590d315a60b11586f9 /android | |
| parent | aa808580fc11b04c8f8a647aad31d87a239fd02f (diff) | |
| download | mullvadvpn-4ef5633fca6e22c6059ef9bc3cf704ad0cb7bd40.tar.xz mullvadvpn-4ef5633fca6e22c6059ef9bc3cf704ad0cb7bd40.zip | |
Update lint baseline
Diffstat (limited to 'android')
| -rw-r--r-- | android/app/lint-baseline.xml | 396 |
1 files changed, 0 insertions, 396 deletions
diff --git a/android/app/lint-baseline.xml b/android/app/lint-baseline.xml index f458d4087e..89c31a63bb 100644 --- a/android/app/lint-baseline.xml +++ b/android/app/lint-baseline.xml @@ -48,17 +48,6 @@ <issue id="ScrollViewSize" message="This LinearLayout should use `android:layout_height="wrap_content"`" - errorLine1=" android:layout_height="match_parent"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/connect.xml" - line="23" - column="27"/> - </issue> - - <issue - id="ScrollViewSize" - message="This LinearLayout should use `android:layout_height="wrap_content"`" errorLine1=" android:layout_height="match_parent"" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location @@ -312,28 +301,6 @@ <issue id="UseCompatLoadingForDrawables" message="Use `ResourcesCompat.getDrawable()`" - errorLine1=" private val greenBackground = resources.getDrawable(R.drawable.green_button_background, null)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/ui/ConnectActionButton.kt" - line="16" - column="35"/> - </issue> - - <issue - id="UseCompatLoadingForDrawables" - message="Use `ResourcesCompat.getDrawable()`" - errorLine1=" resources.getDrawable(R.drawable.transparent_red_left_half_button_background, null)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/ui/ConnectActionButton.kt" - line="18" - column="9"/> - </issue> - - <issue - id="UseCompatLoadingForDrawables" - message="Use `ResourcesCompat.getDrawable()`" errorLine1=" private val errorImage = resources.getDrawable(R.drawable.icon_notification_error, null)" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location @@ -355,28 +322,6 @@ <issue id="UseCompatLoadingForDrawables" - message="Use `ResourcesCompat.getDrawable()`" - errorLine1=" val activeRelayIcon = resources.getDrawable(R.drawable.icon_relay_active, null)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/relaylist/RelayListAdapter.kt" - line="17" - column="27"/> - </issue> - - <issue - id="UseCompatLoadingForDrawables" - message="Use `ResourcesCompat.getDrawable()`" - errorLine1=" val inactiveRelayIcon = resources.getDrawable(R.drawable.icon_relay_inactive, null)" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/relaylist/RelayListAdapter.kt" - line="18" - column="29"/> - </issue> - - <issue - id="UseCompatLoadingForDrawables" message="Use `AppCompatResources.getDrawable()`" errorLine1=" super.detailImage = context.getDrawable(R.drawable.icon_extlink)" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -772,17 +717,6 @@ </issue> <issue - id="NotifyDataSetChanged" - message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort." - errorLine1=" notifyDataSetChanged()" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/relaylist/RelayListAdapter.kt" - line="64" - column="13"/> - </issue> - - <issue id="ObsoleteSdkInt" message="This folder configuration (`v26`) is unnecessary; `minSdkVersion` is 26. Merge all the resources in this folder into `mipmap-anydpi`."> <location @@ -790,17 +724,6 @@ </issue> <issue - id="UseCompoundDrawables" - message="This tag and its children can be replaced by one `<TextView/>` and a compound drawable" - errorLine1=" <LinearLayout android:layout_width="wrap_content"" - errorLine2=" ~~~~~~~~~~~~"> - <location - file="src/main/res/layout/connect.xml" - line="79" - column="26"/> - </issue> - - <issue id="VectorPath" message="Very long vector path (917 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector." errorLine1=" <path android:fillColor="#66294D73"" @@ -880,17 +803,6 @@ <issue id="InefficientWeight" message="Use a `layout_height` of `0dp` instead of `wrap_content` for better performance" - errorLine1=" android:layout_height="wrap_content"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/connect.xml" - line="71" - column="35"/> - </issue> - - <issue - id="InefficientWeight" - message="Use a `layout_height` of `0dp` instead of `wrap_content` for better performance" errorLine1=" android:layout_height="wrap_content"" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location @@ -935,17 +847,6 @@ <issue id="NestedWeights" message="Nested weights are bad for performance" - errorLine1=" android:layout_weight="0"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/connect.xml" - line="72" - column="35"/> - </issue> - - <issue - id="NestedWeights" - message="Nested weights are bad for performance" errorLine1=" android:layout_weight="1" />" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> <location @@ -993,28 +894,6 @@ errorLine1=" android:background="@color/darkBlue"" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="src/main/res/layout/select_location.xml" - line="4" - column="14"/> - </issue> - - <issue - id="Overdraw" - message="Possible overdraw: Root element paints background `@color/darkBlue` with a theme that also paints a background (inferred theme is `@style/AppTheme`)" - errorLine1=" android:background="@color/darkBlue"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/settings.xml" - line="5" - column="14"/> - </issue> - - <issue - id="Overdraw" - message="Possible overdraw: Root element paints background `@color/darkBlue` with a theme that also paints a background (inferred theme is `@style/AppTheme`)" - errorLine1=" android:background="@color/darkBlue"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location file="src/main/res/layout/split_tunneling.xml" line="5" column="14"/> @@ -1407,28 +1286,6 @@ <issue id="ContentDescription" message="Missing `contentDescription` attribute on image" - errorLine1=" <ImageView android:id="@+id/chevron"" - errorLine2=" ~~~~~~~~~"> - <location - file="src/main/res/layout/connect.xml" - line="89" - column="30"/> - </issue> - - <issue - id="ContentDescription" - message="Missing `contentDescription` attribute on image" - errorLine1=" <ImageButton android:id="@+id/reconnect_button"" - errorLine2=" ~~~~~~~~~~~"> - <location - file="src/main/res/layout/connect.xml" - line="137" - column="26"/> - </issue> - - <issue - id="ContentDescription" - message="Missing `contentDescription` attribute on image" errorLine1=" <ImageView android:id="@+id/appIcon"" errorLine2=" ~~~~~~~~~"> <location @@ -1528,61 +1385,6 @@ <issue id="ContentDescription" message="Missing `contentDescription` attribute on image" - errorLine1=" <ImageView android:id="@+id/relay_active"" - errorLine2=" ~~~~~~~~~"> - <location - file="src/main/res/layout/relay_list_item.xml" - line="23" - column="14"/> - </issue> - - <issue - id="ContentDescription" - message="Missing `contentDescription` attribute on image" - errorLine1=" <ImageView android:id="@+id/selected"" - errorLine2=" ~~~~~~~~~"> - <location - file="src/main/res/layout/relay_list_item.xml" - line="28" - column="14"/> - </issue> - - <issue - id="ContentDescription" - message="Missing `contentDescription` attribute on image" - errorLine1=" <ImageButton android:id="@+id/chevron"" - errorLine2=" ~~~~~~~~~~~"> - <location - file="src/main/res/layout/relay_list_item.xml" - line="46" - column="6"/> - </issue> - - <issue - id="ContentDescription" - message="Missing `contentDescription` attribute on image" - errorLine1=" <ImageButton android:id="@+id/close"" - errorLine2=" ~~~~~~~~~~~"> - <location - file="src/main/res/layout/select_location.xml" - line="16" - column="14"/> - </issue> - - <issue - id="ContentDescription" - message="Missing `contentDescription` attribute on image" - errorLine1=" <ImageButton android:id="@+id/close"" - errorLine2=" ~~~~~~~~~~~"> - <location - file="src/main/res/layout/settings.xml" - line="17" - column="14"/> - </issue> - - <issue - id="ContentDescription" - message="Missing `contentDescription` attribute on image" errorLine1=" <ImageView android:layout_width="24dp"" errorLine2=" ~~~~~~~~~"> <location @@ -1614,50 +1416,6 @@ </issue> <issue - id="SetTextI18n" - message="Do not concatenate text displayed with `setText`. Use resource string with placeholders." - errorLine1=" inAddress.text = context.getString(R.string.in_address) + " $host:$port $protocol"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/ui/LocationInfo.kt" - line="119" - column="30"/> - </issue> - - <issue - id="SetTextI18n" - message="Do not concatenate text displayed with `setText`. Use resource string with placeholders." - errorLine1=" inAddress.text = context.getString(R.string.in_address) + " $host:$port $protocol"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/ui/LocationInfo.kt" - line="119" - column="71"/> - </issue> - - <issue - id="SetTextI18n" - message="Do not concatenate text displayed with `setText`. Use resource string with placeholders." - errorLine1=" outAddress.text = context.getString(R.string.out_address) + " $ipAddress"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/ui/LocationInfo.kt" - line="141" - column="31"/> - </issue> - - <issue - id="SetTextI18n" - message="Do not concatenate text displayed with `setText`. Use resource string with placeholders." - errorLine1=" outAddress.text = context.getString(R.string.out_address) + " $ipAddress"" - errorLine2=" ~~~~~~~~~~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/ui/LocationInfo.kt" - line="141" - column="73"/> - </issue> - - <issue id="RtlSymmetry" message="When you define `paddingRight` you should probably also define `paddingLeft` for right-to-left symmetry" errorLine1=" android:paddingRight="@dimen/cell_inner_spacing"" @@ -1670,28 +1428,6 @@ <issue id="RtlHardcoded" - message="Use "`Gravity.END`" instead of "`Gravity.RIGHT`" to ensure correct behavior in right-to-left locales" - errorLine1=" gravity = Gravity.RIGHT" - errorLine2=" ~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/ui/widget/AppVersionCell.kt" - line="31" - column="31"/> - </issue> - - <issue - id="RtlHardcoded" - message="Use "`Gravity.END`" instead of "`Gravity.RIGHT`" to ensure correct behavior in right-to-left locales" - errorLine1=" gravity = Gravity.RIGHT" - errorLine2=" ~~~~~"> - <location - file="src/main/kotlin/net/mullvad/mullvadvpn/ui/widget/AppVersionCell.kt" - line="31" - column="31"/> - </issue> - - <issue - id="RtlHardcoded" message="Use "`Gravity.START`" instead of "`Gravity.LEFT`" to ensure correct behavior in right-to-left locales" errorLine1=" gravity = Gravity.CENTER_VERTICAL or Gravity.LEFT" errorLine2=" ~~~~"> @@ -1879,17 +1615,6 @@ <issue id="RtlHardcoded" - message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart="1dp"` to better support right-to-left layouts" - errorLine1=" android:layout_marginLeft="1dp"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/connect.xml" - line="140" - column="38"/> - </issue> - - <issue - id="RtlHardcoded" message="Consider replacing `android:paddingLeft` with `android:paddingStart="16dp"` to better support right-to-left layouts" errorLine1=" android:paddingLeft="16dp"" errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -2011,116 +1736,6 @@ <issue id="RtlHardcoded" - message="Consider replacing `android:layout_alignParentLeft` with `android:layout_alignParentStart="true"` to better support right-to-left layouts" - errorLine1=" android:layout_alignParentLeft="true"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/relay_list_item.xml" - line="12" - column="15"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider replacing `android:layout_alignParentRight` with `android:layout_alignParentEnd="true"` to better support right-to-left layouts" - errorLine1=" android:layout_alignParentRight="true"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/relay_list_item.xml" - line="13" - column="15"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider replacing `android:layout_alignParentLeft` with `android:layout_alignParentStart="true"` to better support right-to-left layouts" - errorLine1=" android:layout_alignParentLeft="true"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/relay_list_item.xml" - line="20" - column="22"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart="@dimen/country_row_padding"` to better support right-to-left layouts" - errorLine1=" android:layout_marginLeft="@dimen/country_row_padding">" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/relay_list_item.xml" - line="22" - column="22"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider replacing `android:layout_alignParentRight` with `android:layout_alignParentEnd="true"` to better support right-to-left layouts" - errorLine1=" android:layout_alignParentRight="true"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/relay_list_item.xml" - line="39" - column="19"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider replacing `android:layout_toRightOf` with `android:layout_toEndOf="@id/status"` to better support right-to-left layouts" - errorLine1=" android:layout_toRightOf="@id/status"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/relay_list_item.xml" - line="40" - column="19"/> - </issue> - - <issue - id="RtlHardcoded" - message="Use "`start`" instead of "`left`" to ensure correct behavior in right-to-left locales" - errorLine1=" android:gravity="left">" - errorLine2=" ~~~~"> - <location - file="src/main/res/layout/select_location.xml" - line="5" - column="31"/> - </issue> - - <issue - id="RtlHardcoded" - message="Use "`start`" instead of "`left`" to ensure correct behavior in right-to-left locales" - errorLine1=" android:gravity="left">" - errorLine2=" ~~~~"> - <location - file="src/main/res/layout/select_location_header.xml" - line="5" - column="32"/> - </issue> - - <issue - id="RtlHardcoded" - message="Use "`start`" instead of "`left`" to ensure correct behavior in right-to-left locales" - errorLine1=" android:gravity="left">" - errorLine2=" ~~~~"> - <location - file="src/main/res/layout/settings.xml" - line="6" - column="31"/> - </issue> - - <issue - id="RtlHardcoded" - message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart="@dimen/side_margin"` to better support right-to-left layouts" - errorLine1=" android:layout_marginLeft="@dimen/side_margin"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/settings.xml" - line="42" - column="27"/> - </issue> - - <issue - id="RtlHardcoded" message="Consider replacing `android:layout_marginRight` with `android:layout_marginEnd="8dp"` to better support right-to-left layouts" errorLine1=" android:layout_marginRight="8dp"" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -2198,17 +1813,6 @@ <issue id="RtlHardcoded" - message="Consider replacing `android:drawableRight` with `android:drawableEnd="@drawable/icon_chevron"` to better support right-to-left layouts" - errorLine1=" android:drawableRight="@drawable/icon_chevron"" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> - <location - file="src/main/res/layout/switch_location_button.xml" - line="11" - column="13"/> - </issue> - - <issue - id="RtlHardcoded" message="Use "`start`" instead of "`left`" to ensure correct behavior in right-to-left locales" errorLine1=" android:gravity="left"" errorLine2=" ~~~~"> |