summaryrefslogtreecommitdiffhomepage
path: root/audits
diff options
context:
space:
mode:
authoromahs <73983677+omahs@users.noreply.github.com>2025-05-11 09:49:55 +0200
committeromahs <73983677+omahs@users.noreply.github.com>2025-06-05 14:21:09 +0000
commit73fcc2275c1a0bccb9e849d352e2bbd637f141e6 (patch)
treea3719f7afc5b9004af683b540ddcce2cdf7911c2 /audits
parent6f05ce41a5cf9edd5b8e3a734bcf2eb89b53a44a (diff)
downloadmullvadvpn-73fcc2275c1a0bccb9e849d352e2bbd637f141e6.tar.xz
mullvadvpn-73fcc2275c1a0bccb9e849d352e2bbd637f141e6.zip
Fix typos
Diffstat (limited to 'audits')
-rw-r--r--audits/2025-03-20-assured-installer-downloader.md8
-rw-r--r--audits/README.md2
2 files changed, 5 insertions, 5 deletions
diff --git a/audits/2025-03-20-assured-installer-downloader.md b/audits/2025-03-20-assured-installer-downloader.md
index 1d3781c6a0..c7f15543c1 100644
--- a/audits/2025-03-20-assured-installer-downloader.md
+++ b/audits/2025-03-20-assured-installer-downloader.md
@@ -35,7 +35,7 @@ to them.
The script we use to automate part of the desktop app release process (`4-make-release`) uses
`gpg --verify` to ensure that the installers it has fetched from Mullvad's internal release
servers are not tampered with.
-Both the installer and the accompanying signature comes from the same server.
+Both the installer and the accompanying signature come from the same server.
The audit report claims that `gpg --verify` will succeed as long as the signature matches the data,
no matter which key produced the signature. This claim is not fully accurate according
@@ -54,7 +54,7 @@ identified two potential risks here:
The manpage for `gpg` explicitly states that only using the exit code, like we do, for signature
validation is not appropriate. So Assured is correct in pointing out this behavior as risky.
-Both Assured and the manpage for `gpg` recommends `gpgv` as an alternative for usage in scripts.
+Both Assured and the manpage for `gpg` recommend `gpgv` as an alternative for usage in scripts.
However, even `gpgv` is a bit unclear about how it handles key servers and bundled pubkeys.
So instead we decided use [Sequoia] to verify the signatures, as it allows explicitly specifying
what PGP pubkey to trust. It also does not require us to initialize any keyring, so it is simpler
@@ -83,7 +83,7 @@ The recommendation here is to deserialize `canon_json` and return that as the tr
A sidenote here is that the code was initially implemented according to the recommendation.
The code was changed to return `partial_data.signed` just before the audit. This change was
-a result of a pre-audit meeting between Mullvad and Assured where we probably missunderstood
+a result of a pre-audit meeting between Mullvad and Assured where we probably misunderstood
some of their early feedback on the metadata verification best practices.
We [changed the implementation back] to only use the verified data, as recommended.
@@ -97,7 +97,7 @@ We [changed the implementation back] to only use the verified data, as recommend
The macOS version of the installer downloader runs as the user who launched it. The program will
save the downloaded installer to a temporary directory writable by the user. The installer
downloader will then verify the checksum of the file and launch it if it matches. This leaves
-a possible Time-of-Check, Time-of-Use (TOCTOU) attack vector. Any program running as the the same
+a possible Time-of-Check, Time-of-Use (TOCTOU) attack vector. Any program running as the same
user can replace the installer downloader between the time it was verified and it was launched.
Causing the installer downloader to launch a potentially malicious installer.
diff --git a/audits/README.md b/audits/README.md
index d4bc09a9f1..1fff379a68 100644
--- a/audits/README.md
+++ b/audits/README.md
@@ -14,7 +14,7 @@ performed on this app so far:
## Additional audits and certifications
-Apart from the biannual audits mentioned above, we've also conducted the the following:
+Apart from the biannual audits mentioned above, we've also conducted the following:
* [2025-02-24 - NCC Group Mobile Application Security Assessment (MASA) of the Android app](./2025-02-24-nccgroup-android-masa.md)
* [2025-03-20 - Audit of the installer downloader by Assured](./2025-03-20-assured-installer-downloader.md) \ No newline at end of file