summaryrefslogtreecommitdiffhomepage
path: root/gui/src/renderer
diff options
context:
space:
mode:
authorOskar Nyberg <oskar@mullvad.net>2022-05-11 13:46:52 +0200
committerOskar Nyberg <oskar@mullvad.net>2022-05-11 13:46:52 +0200
commitcb8712d758e120fde518f384fa3409683537adff (patch)
treee554b1451b1a0c6001fa5eedf44dca291187d655 /gui/src/renderer
parenteb8c374b4dfff70a3b76b9ee36b248e8cb57e483 (diff)
downloadmullvadvpn-cb8712d758e120fde518f384fa3409683537adff.tar.xz
mullvadvpn-cb8712d758e120fde518f384fa3409683537adff.zip
Handle error when failing to fetch devices
Diffstat (limited to 'gui/src/renderer')
-rw-r--r--gui/src/renderer/app.tsx15
-rw-r--r--gui/src/renderer/components/TooManyDevices.tsx6
2 files changed, 14 insertions, 7 deletions
diff --git a/gui/src/renderer/app.tsx b/gui/src/renderer/app.tsx
index d4672066f2..d6911da317 100644
--- a/gui/src/renderer/app.tsx
+++ b/gui/src/renderer/app.tsx
@@ -299,9 +299,18 @@ export default class AppRenderer {
} catch (e) {
const error = e as Error;
if (error.message === 'Too many devices') {
- actions.account.loginTooManyDevices(error);
- this.loginState = 'too many devices';
- this.history.reset(RoutePath.tooManyDevices, transitions.push);
+ try {
+ await this.fetchDevices(accountToken);
+
+ actions.account.loginTooManyDevices(error);
+ this.loginState = 'too many devices';
+
+ this.history.reset(RoutePath.tooManyDevices, transitions.push);
+ } catch (e) {
+ const error = e as Error;
+ log.error('Failed to fetch device list');
+ actions.account.loginFailed(error);
+ }
} else {
actions.account.loginFailed(error);
}
diff --git a/gui/src/renderer/components/TooManyDevices.tsx b/gui/src/renderer/components/TooManyDevices.tsx
index 7cb67bf040..3823cc6f5d 100644
--- a/gui/src/renderer/components/TooManyDevices.tsx
+++ b/gui/src/renderer/components/TooManyDevices.tsx
@@ -1,4 +1,4 @@
-import { useCallback, useEffect } from 'react';
+import { useCallback } from 'react';
import { sprintf } from 'sprintf-js';
import styled from 'styled-components';
@@ -99,7 +99,7 @@ const StyledRemoveSpinner = styled(ImageView)({
export default function TooManyDevices() {
const history = useHistory();
- const { fetchDevices, removeDevice, login, cancelLogin } = useAppContext();
+ const { removeDevice, login, cancelLogin } = useAppContext();
const accountToken = useSelector((state) => state.account.accountToken)!;
const devices = useSelector((state) => state.account.devices);
@@ -116,8 +116,6 @@ export default function TooManyDevices() {
history.reset(RoutePath.login, transitions.pop);
}, [history.reset, cancelLogin]);
- useEffect(() => void fetchDevices(accountToken), []);
-
const iconSource = getIconSource(devices);
const title = getTitle(devices);
const subtitle = getSubtitle(devices);