Code cleanup

- Rename `mullvad_types::api_access.rs` -> `mullvad_types::access_method.rs`

- Rename `ApiAccessMethodId` to simply `Id`
  Prefer to prefix with module name `access_method` to disambiguate use
  of `Id` instead, like `access_method::Id`

- Remove dead code
  - Remove `AccessMethodSettingsUpdate`
  - Remove the `retry_attempt` struct field from
  `ApiConnectionModeProvider`, as it is no longer used for anything.

- Fix typos
  - `GetApiAddressess` is now correctly spelled `GetApiAddresses` (a
  single trailing "s")

- Deprecate the name `ApiAccessMethod` in favor of `AccessMethodSetting`
  - To decrease the confusion between `AccessMethod` &
  `ApiAccessMethod`. `AccessMethodSetting` adds some app-specific
  settings details on top of an `AccessMethod`, which is not too far
  fetched with the new naming convention.

- Refactor proto file

  - Rename protobuf message `AccessMethodSettingAdd` to `NewAccessMethodSetting`
  - `AccessMethod` is now its own message
  - `AccessMethods` is removed
  - Add `ApiAccessMethodAdd` protobuf message
    - The `ApiAccessMethodAdd` returns a `UUID` for the . One important
    change is that new `AccessMethodSetting`s are created in the daemon,
    rather than in the CLI/other clients. This means that the daemon now
    has full control over generating new `AccessMethodSetting`s from
    `AccessMethod`s.
    - Clean up conversion code to/from `AccessMethod` protobuf types
    - Simplify `UpdateApiAccessMethod` RPC
    - Remove the extranous `ApiAccessMethodUpdate` data type
    - get rid of `ApiAccessMethodUpdate` protobuf message. Use `UUID` of
    `ApiAccessMethod` to identify which struct to edit.
    - get rid of `ApiAccessMethodUpdate` struct

0 files changed, 0 insertions, 0 deletions