summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorBrad Fitzpatrick <bradfitz@tailscale.com>2024-09-04 16:57:32 -0700
committerBrad Fitzpatrick <brad@danga.com>2024-09-04 17:08:33 -0700
commit13dee9db7bc09df36be593641cb3667584e64b60 (patch)
treea71dfa5ea3fe89bec8a8e9491144a27b24de02a9
parent3d401c11fab13e354946c89c236cb2c1a941a5f2 (diff)
downloadtailscale-13dee9db7bc09df36be593641cb3667584e64b60.tar.xz
tailscale-13dee9db7bc09df36be593641cb3667584e64b60.zip
health: fix magicsockReceiveFuncWarnable health clearing
Fixes #13204 Change-Id: I7154cdabc9dc362dcc3221fd5a86e21f610bbff0 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
-rw-r--r--health/health.go3
1 files changed, 2 insertions, 1 deletions
diff --git a/health/health.go b/health/health.go
index 1faab53f9..7bb9d18e9 100644
--- a/health/health.go
+++ b/health/health.go
@@ -1064,7 +1064,7 @@ func (t *Tracker) updateBuiltinWarnablesLocked() {
_ = t.lastStreamedMapResponse
_ = t.lastMapRequestHeard
- shouldClearMagicsockWarnings := false
+ shouldClearMagicsockWarnings := true
for i := range t.MagicSockReceiveFuncs {
f := &t.MagicSockReceiveFuncs[i]
if f.missing {
@@ -1072,6 +1072,7 @@ func (t *Tracker) updateBuiltinWarnablesLocked() {
ArgMagicsockFunctionName: f.name,
})
shouldClearMagicsockWarnings = false
+ break
}
}
if shouldClearMagicsockWarnings {