diff options
| author | Josh Bleecher Snyder <josh@tailscale.com> | 2021-02-08 13:34:27 -0800 |
|---|---|---|
| committer | Josh Bleecher Snyder <josh@tailscale.com> | 2021-02-08 13:55:35 -0800 |
| commit | c274f818e7556c1460f34160933ed5b7c72787c5 (patch) | |
| tree | 396b36d37a19fcb965ce39fb6d4392572ee66954 | |
| parent | e1f773ebba87971d7da49c20fbb7f1e73b2b5ee7 (diff) | |
| download | tailscale-josh/remove-ipcgetfilter.tar.xz tailscale-josh/remove-ipcgetfilter.zip | |
wgengine: remove IpcGetOperation filterjosh/remove-ipcgetfilter
This was in place because retrieved allowed_ips was very expensive.
Upstream changed the data structure to make them cheaper to compute.
This commit is an experiment to find out whether they're now cheap enough.
Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
| -rw-r--r-- | wgengine/userspace.go | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/wgengine/userspace.go b/wgengine/userspace.go index 282b79c7d..5793232b4 100644 --- a/wgengine/userspace.go +++ b/wgengine/userspace.go @@ -1075,12 +1075,7 @@ func (e *userspaceEngine) getStatus() (*Status, error) { defer pw.Close() // TODO(apenwarr): get rid of silly uapi stuff for in-process comms // FIXME: get notified of status changes instead of polling. - filter := device.IPCGetFilter{ - // The allowed_ips are somewhat expensive to compute and they're - // unused below; request that they not be sent instead. - FilterAllowedIPs: true, - } - err := e.wgdev.IpcGetOperationFiltered(pw, filter) + err := e.wgdev.IpcGetOperation(pw) if err != nil { err = fmt.Errorf("IpcGetOperation: %w", err) } |
