Immediately access shares when adding themoxtoacart/immediately_access_shares

1 files changed, 19 insertions, 0 deletions

diff --git a/ipn/ipnlocal/tailfs.go b/ipn/ipnlocal/tailfs.go
index d06599661..fc5e5e16f 100644
--- a/ipn/ipnlocal/tailfs.go
+++ b/ipn/ipnlocal/tailfs.go
@@ -80,6 +80,25 @@ func (b *LocalBackend) TailFSAddShare(share *tailfs.Share) error {
 		return err
 	}
 
+	// Make sure share is actually a directory.
+	dir, err := os.Open(share.Name)
+	if err != nil {
+		return err
+	}
+	fi, err := dir.Stat()
+	if err != nil {
+		return err
+	}
+	if !fi.IsDir() {
+		return fmt.Errorf("%q is not a directory", share.Name)
+	}
+	// Immediately access each share to prompt the user for file access on
+	// platforms that require it (e.g. MacOS sandboxed).
+	_, err = dir.ReadDir(1)
+	if err != nil {
+		return err
+	}
+
 	b.mu.Lock()
 	shares, err := b.tailfsAddShareLocked(share)
 	b.mu.Unlock()