diff options
| author | James Tucker <james@tailscale.com> | 2023-11-09 17:26:27 -0800 |
|---|---|---|
| committer | James Tucker <james@tailscale.com> | 2023-11-09 17:26:27 -0800 |
| commit | 1b1895245028a7e2ad72824c4cbc86237774f511 (patch) | |
| tree | 7059d315c974316a44b36d57a5759ec0acbb24bd | |
| parent | 933d201bbab2c280f9b87b604b0f421678d8d3ba (diff) | |
| download | tailscale-raggi/document-deprecated-approach.tar.xz tailscale-raggi/document-deprecated-approach.zip | |
ipn/policy,tailcfg: document desire to not extend peerapi service advertisements in hostinforaggi/document-deprecated-approach
Updates #cleanup
Signed-off-by: James Tucker <james@tailscale.com>
| -rw-r--r-- | ipn/policy/policy.go | 2 | ||||
| -rw-r--r-- | tailcfg/tailcfg.go | 3 |
2 files changed, 5 insertions, 0 deletions
diff --git a/ipn/policy/policy.go b/ipn/policy/policy.go index 8703b71ae..bf2aa84d3 100644 --- a/ipn/policy/policy.go +++ b/ipn/policy/policy.go @@ -14,6 +14,8 @@ import ( // to our peer nodes for discovery purposes. func IsInterestingService(s tailcfg.Service, os string) bool { switch s.Proto { + // Avoid further extension of this approach to advertising peer services. + // TODO(bradfitz,raggi): point to preferred approach case tailcfg.PeerAPI4, tailcfg.PeerAPI6, tailcfg.PeerAPIDNS, tailcfg.AppConnector: return true } diff --git a/tailcfg/tailcfg.go b/tailcfg/tailcfg.go index 54f3b24f7..f1eb5f8b6 100644 --- a/tailcfg/tailcfg.go +++ b/tailcfg/tailcfg.go @@ -653,6 +653,9 @@ type Service struct { // * "app-connector": the local app-connector service is // available. For this service, the Port number is // really the version number of the service. + // + // Avoid further extension of this approach to advertising peer services. + // TODO(bradfitz,raggi): point to preferred approach Proto ServiceProto // Port is the port number. |