diff options
| author | Josh Bleecher Snyder <josh@tailscale.com> | 2021-08-09 17:31:29 -0700 |
|---|---|---|
| committer | Josh Bleecher Snyder <josharian@gmail.com> | 2021-08-09 22:46:01 -0700 |
| commit | a4e19f22339d9d618dcf459ca5709b2701aada56 (patch) | |
| tree | 228cad3804d40b7f132c16f3cc22463031b33d73 /cmd | |
| parent | bdb93c5942998f90db4e528bc5ab09076a3c8801 (diff) | |
| download | tailscale-a4e19f22339d9d618dcf459ca5709b2701aada56.tar.xz tailscale-a4e19f22339d9d618dcf459ca5709b2701aada56.zip | |
version: remove rsc.io/goversion dependency
rsc.io/goversion is really expensive.
Running version.ReadExe on tailscaled on darwin
allocates 47k objects, almost 11mb.
All we want is the module info. For that, all we need to do
is scan through the binary looking for the magic start/end strings
and then grab the bytes in between them.
We can do that easily and quickly with nothing but a 64k buffer.
Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/tailscale/depaware.txt | 15 | ||||
| -rw-r--r-- | cmd/tailscaled/depaware.txt | 13 |
2 files changed, 7 insertions, 21 deletions
diff --git a/cmd/tailscale/depaware.txt b/cmd/tailscale/depaware.txt index 5d1a82974..cfd67c673 100644 --- a/cmd/tailscale/depaware.txt +++ b/cmd/tailscale/depaware.txt @@ -20,7 +20,6 @@ tailscale.com/cmd/tailscale dependencies: (generated by github.com/tailscale/dep go4.org/unsafe/assume-no-moving-gc from go4.org/intern W 💣 golang.zx2c4.com/wireguard/windows/tunnel/winipcfg from tailscale.com/net/interfaces+ inet.af/netaddr from tailscale.com/cmd/tailscale/cli+ - rsc.io/goversion/version from tailscale.com/version tailscale.com/atomicfile from tailscale.com/ipn tailscale.com/client/tailscale from tailscale.com/cmd/tailscale/cli+ tailscale.com/client/tailscale/apitype from tailscale.com/client/tailscale+ @@ -101,9 +100,8 @@ tailscale.com/cmd/tailscale dependencies: (generated by github.com/tailscale/dep golang.org/x/time/rate from tailscale.com/cmd/tailscale/cli+ bufio from compress/flate+ bytes from bufio+ - compress/flate from compress/gzip+ + compress/flate from compress/gzip compress/gzip from net/http - compress/zlib from debug/elf+ container/list from crypto/tls+ context from crypto/tls+ crypto from crypto/ecdsa+ @@ -126,10 +124,6 @@ tailscale.com/cmd/tailscale dependencies: (generated by github.com/tailscale/dep crypto/tls from github.com/tcnksm/go-httpstat+ crypto/x509 from crypto/tls+ crypto/x509/pkix from crypto/x509+ - debug/dwarf from debug/elf+ - debug/elf from rsc.io/goversion/version - debug/macho from rsc.io/goversion/version - debug/pe from rsc.io/goversion/version embed from tailscale.com/cmd/tailscale/cli encoding from encoding/json+ encoding/asn1 from crypto/x509+ @@ -143,8 +137,7 @@ tailscale.com/cmd/tailscale dependencies: (generated by github.com/tailscale/dep expvar from tailscale.com/derp+ flag from github.com/peterbourgon/ff/v2+ fmt from compress/flate+ - hash from compress/zlib+ - hash/adler32 from compress/zlib + hash from crypto+ hash/crc32 from compress/gzip+ hash/maphash from go4.org/mem html from tailscale.com/ipn/ipnstate+ @@ -171,10 +164,10 @@ tailscale.com/cmd/tailscale dependencies: (generated by github.com/tailscale/dep os/exec from github.com/toqueteos/webbrowser+ os/signal from tailscale.com/cmd/tailscale/cli os/user from tailscale.com/util/groupmember - path from debug/dwarf+ + path from html/template+ path/filepath from crypto/x509+ reflect from crypto/x509+ - regexp from rsc.io/goversion/version+ + regexp from github.com/tailscale/goupnp/httpu+ regexp/syntax from regexp runtime/debug from golang.org/x/sync/singleflight sort from compress/flate+ diff --git a/cmd/tailscaled/depaware.txt b/cmd/tailscaled/depaware.txt index 41dde5cca..4e5ab8c59 100644 --- a/cmd/tailscaled/depaware.txt +++ b/cmd/tailscaled/depaware.txt @@ -87,7 +87,6 @@ tailscale.com/cmd/tailscaled dependencies: (generated by github.com/tailscale/de inet.af/netstack/waiter from inet.af/netstack/tcpip+ inet.af/peercred from tailscale.com/ipn/ipnserver W 💣 inet.af/wf from tailscale.com/wf - rsc.io/goversion/version from tailscale.com/version tailscale.com/atomicfile from tailscale.com/ipn+ tailscale.com/client/tailscale from tailscale.com/derp tailscale.com/client/tailscale/apitype from tailscale.com/ipn/ipnlocal+ @@ -216,9 +215,8 @@ tailscale.com/cmd/tailscaled dependencies: (generated by github.com/tailscale/de golang.org/x/time/rate from inet.af/netstack/tcpip/stack+ bufio from compress/flate+ bytes from bufio+ - compress/flate from compress/gzip+ + compress/flate from compress/gzip compress/gzip from internal/profile+ - compress/zlib from debug/elf+ container/heap from inet.af/netstack/tcpip/transport/tcp container/list from crypto/tls+ context from crypto/tls+ @@ -242,10 +240,6 @@ tailscale.com/cmd/tailscaled dependencies: (generated by github.com/tailscale/de crypto/tls from github.com/tcnksm/go-httpstat+ crypto/x509 from crypto/tls+ crypto/x509/pkix from crypto/x509+ - debug/dwarf from debug/elf+ - debug/elf from rsc.io/goversion/version - debug/macho from rsc.io/goversion/version - debug/pe from rsc.io/goversion/version embed from tailscale.com/net/dns+ encoding from encoding/json+ encoding/asn1 from crypto/x509+ @@ -259,8 +253,7 @@ tailscale.com/cmd/tailscaled dependencies: (generated by github.com/tailscale/de expvar from tailscale.com/derp+ flag from tailscale.com/cmd/tailscaled+ fmt from compress/flate+ - hash from compress/zlib+ - hash/adler32 from compress/zlib + hash from crypto+ hash/crc32 from compress/gzip+ hash/fnv from tailscale.com/wgengine/magicsock+ hash/maphash from go4.org/mem @@ -288,7 +281,7 @@ tailscale.com/cmd/tailscaled dependencies: (generated by github.com/tailscale/de os/exec from github.com/coreos/go-iptables/iptables+ os/signal from tailscale.com/cmd/tailscaled+ os/user from github.com/godbus/dbus/v5+ - path from debug/dwarf+ + path from github.com/godbus/dbus/v5+ path/filepath from crypto/x509+ reflect from crypto/x509+ regexp from github.com/coreos/go-iptables/iptables+ |