diff options
| author | Mario Minardi <mario@tailscale.com> | 2025-01-08 13:20:31 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-08 13:20:31 -0700 |
| commit | 0b4ba4074f584af28fd34945a4bf62d559b2c64d (patch) | |
| tree | 13d843df405b3eb83d80e97b469203c0f0a75208 /control/controlhttp/controlhttpserver/controlhttpserver.go | |
| parent | fa52035574fd6e9d6896b39f683ed67946a73dbd (diff) | |
| download | tailscale-0b4ba4074f584af28fd34945a4bf62d559b2c64d.tar.xz tailscale-0b4ba4074f584af28fd34945a4bf62d559b2c64d.zip | |
client/web: properly show "Log In" for web client on fresh install (#14569)
Change the type of the `IPv4` and `IPv6` members in the `nodeData`
struct to be `netip.Addr` instead of `string`.
We were previously calling `String()` on this struct, which returns
"invalid IP" when the `netip.Addr` is its zero value, and passing this
value into the aforementioned attributes.
This caused rendering issues on the frontend
as we were assuming that the value for `IPv4` and `IPv6` would be falsy
in this case.
The zero value for a `netip.Addr` marshalls to an empty string instead
which is the behaviour we want downstream.
Updates https://github.com/tailscale/tailscale/issues/14568
Signed-off-by: Mario Minardi <mario@tailscale.com>
Diffstat (limited to 'control/controlhttp/controlhttpserver/controlhttpserver.go')
0 files changed, 0 insertions, 0 deletions