diff options
| author | Nick Khyl <nickk@tailscale.com> | 2025-05-29 10:41:23 -0500 |
|---|---|---|
| committer | Nick Khyl <1761190+nickkhyl@users.noreply.github.com> | 2025-05-29 14:28:37 -0500 |
| commit | 191afd3390f08354515af9d6b0c3f6b919b5a0fb (patch) | |
| tree | f51956a998d561996492eb03151d6ab5650e9c59 /control/controlhttp/controlhttpserver/controlhttpserver.go | |
| parent | 4cccd15eeb13d5d7f8f831e5406a567b8f18378b (diff) | |
| download | tailscale-191afd3390f08354515af9d6b0c3f6b919b5a0fb.tar.xz tailscale-191afd3390f08354515af9d6b0c3f6b919b5a0fb.zip | |
net/tshttpproxy: fix WDAP/PAC proxy detection on Win10 1607 and earlier
Using WINHTTP_AUTOPROXY_ALLOW_AUTOCONFIG on Windows versions older than Windows 10 1703 (build 15063)
is not supported and causes WinHttpGetProxyForUrl to fail with ERROR_INVALID_PARAMETER. This results in failures
reaching the control on environments where a proxy is required.
We use wingoes version detection to conditionally set the WINHTTP_AUTOPROXY_ALLOW_AUTOCONFIG flag
on Windows builds greater than 15063.
While there, we also update proxy detection to use WINHTTP_AUTO_DETECT_TYPE_DNS_A, as DNS-based proxy discovery
might be required with Active Directory and in certain other environments.
Updates tailscale/corp#29168
Fixes #879
Signed-off-by: Nick Khyl <nickk@tailscale.com>
Diffstat (limited to 'control/controlhttp/controlhttpserver/controlhttpserver.go')
0 files changed, 0 insertions, 0 deletions