diff options
| author | Simon Law <sfllaw@sfllaw.ca> | 2025-03-14 21:20:12 -0700 |
|---|---|---|
| committer | Adrian Dewhurst <sailor@sailorfrag.net> | 2025-03-27 15:47:26 -0400 |
| commit | 7fc9099cf84d8d9ba4e4d6856511ed607507aa79 (patch) | |
| tree | e883f4e0928f5f898bea61b5f946ac7d14477a0e /control/controlhttp/controlhttpserver/controlhttpserver.go | |
| parent | a3bc0bcb0a42fec00e3f99c4bf17cae0ea8b15dd (diff) | |
| download | tailscale-7fc9099cf84d8d9ba4e4d6856511ed607507aa79.tar.xz tailscale-7fc9099cf84d8d9ba4e4d6856511ed607507aa79.zip | |
cmd/tailscale: fix default for `tailscale set --accept-dns`
The default values for `tailscale up` and `tailscale set` are supposed
to agree on all common flags. But they don’t for `--accept-dns`:
user@host:~$ tailscale up --help 2>&1 | grep -A1 accept-dns
--accept-dns, --accept-dns=false
accept DNS configuration from the admin panel (default true)
user@host:~$ tailscale set --help 2>&1 | grep -A1 accept-dns
--accept-dns, --accept-dns=false
accept DNS configuration from the admin panel
Luckily, `tailscale set` uses `ipn.MaskedPrefs`, so the default values
don’t logically matter. But someone will get the wrong idea if they
trust the `tailscale set --help` documentation.
This patch makes `--accept-dns` default to true in both commands and
also introduces `TestSetDefaultsMatchUpDefaults` to prevent any future
drift.
Fixes: #15319
Signed-off-by: Simon Law <sfllaw@sfllaw.ca>
Diffstat (limited to 'control/controlhttp/controlhttpserver/controlhttpserver.go')
0 files changed, 0 insertions, 0 deletions