diff options
| author | Craig Hesling <craig@hesling.com> | 2025-09-02 02:27:34 -0700 |
|---|---|---|
| committer | Percy Wegmann <ox.to.a.cart@gmail.com> | 2025-09-03 14:28:22 -0500 |
| commit | 2b9d055101a0a2731af9ef5d2caf513bfb7da75e (patch) | |
| tree | 35a429a8ee50531f7893907e4264bc1164eb5b2c /control/controlhttp/controlhttpserver | |
| parent | 0f3598b46741cbd0c005dc7d95c6e24fc8cf1924 (diff) | |
| download | tailscale-2b9d055101a0a2731af9ef5d2caf513bfb7da75e.tar.xz tailscale-2b9d055101a0a2731af9ef5d2caf513bfb7da75e.zip | |
drive: fix StatCache mishandling of paths with spaces
Fix "file not found" errors when WebDAV clients access files/dirs inside
directories with spaces.
The issue occurred because StatCache was mixing URL-escaped and
unescaped paths, causing cache key mismatches.
Specifically, StatCache.set() parsed WebDAV responses containing
URL-escaped paths (ex. "Dir%20Space/file1.txt") and stored them
alongside unescaped cache keys (ex. "Dir Space/file1.txt").
This mismatch prevented StatCache.get() from correctly determining whether
a child file existed.
See https://github.com/tailscale/tailscale/issues/13632#issuecomment-3243522449
for the full explanation of the issue.
The decision to keep all paths references unescaped inside the StatCache
is consistent with net/http.Request.URL.Path and rewrite.go (sole consumer)
Update unit test to detect this directory space mishandling.
Fixes tailscale#13632
Signed-off-by: Craig Hesling <craig@hesling.com>
Diffstat (limited to 'control/controlhttp/controlhttpserver')
0 files changed, 0 insertions, 0 deletions
