diff options
| author | Aaron Klotz <aaron@tailscale.com> | 2022-07-27 13:47:28 -0600 |
|---|---|---|
| committer | Aaron Klotz <aaron@tailscale.com> | 2022-07-27 16:33:57 -0600 |
| commit | 4dbdb19c2658e458325e30afec0e80b818b13b22 (patch) | |
| tree | 9745ca6fd47b6a95a1824ffcf35b9e4aab4fe0c9 /control/controlknobs/controlknobs.go | |
| parent | 446d03e108fad2aa062f8f58bbefd5a248a31a18 (diff) | |
| download | tailscale-4dbdb19c2658e458325e30afec0e80b818b13b22.tar.xz tailscale-4dbdb19c2658e458325e30afec0e80b818b13b22.zip | |
net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak
The definition of winHTTPProxyInfo was using the wrong type (uint16 vs uint32)
for its first field. I fixed that type.
Furthermore, any UTF16 strings returned in that structure must be explicitly
freed. I added code to do this.
Finally, since this is the second time I've seen type safety errors in this code,
I switched the native API calls over to use wrappers generated by mkwinsyscall.
I know that would not have helped prevent the previous two problems, but every
bit helps IMHO.
Updates https://github.com/tailscale/tailscale/issues/4811
Signed-off-by: Aaron Klotz <aaron@tailscale.com>
Diffstat (limited to 'control/controlknobs/controlknobs.go')
0 files changed, 0 insertions, 0 deletions