summaryrefslogtreecommitdiffhomepage
path: root/control/controlknobs/controlknobs.go
diff options
context:
space:
mode:
authorDavid Anderson <danderson@tailscale.com>2022-01-13 13:01:29 -0800
committerDave Anderson <dave@natulte.net>2022-01-13 23:01:29 +0000
commita9da6b73a828774850b88aa08430127c1a732b73 (patch)
tree176f6898b6d29b31287fdf18390d750faee3e967 /control/controlknobs/controlknobs.go
parent9fe5ece8338b4b53233c2be283801241f570b34f (diff)
downloadtailscale-a9da6b73a828774850b88aa08430127c1a732b73.tar.xz
tailscale-a9da6b73a828774850b88aa08430127c1a732b73.zip
net/dnscache: don't cancel the TLS context before writing to the result channel.
Cancelling the context makes the timeout goroutine race with the write that reports a successful TLS handshake, so you can end up with a successful TLS handshake that mysteriously reports that it timed out after ~0s in flight. The context is always canceled and cleaned up as the function exits, which happens mere microseconds later, so just let function exit clean up and thereby avoid races. Signed-off-by: David Anderson <danderson@tailscale.com>
Diffstat (limited to 'control/controlknobs/controlknobs.go')
0 files changed, 0 insertions, 0 deletions