diff options
| author | Brad Fitzpatrick <bradfitz@tailscale.com> | 2024-07-01 13:30:58 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <brad@danga.com> | 2024-07-01 14:40:51 -0700 |
| commit | b56058d7e32f6a0d6d163f55771174dc79776839 (patch) | |
| tree | 9844c92ec59d7e8372a141884f3414436edce3bd /control/controlknobs/controlknobs.go | |
| parent | d7807553408672480984077a2bc973442a7b4d42 (diff) | |
| download | tailscale-b56058d7e32f6a0d6d163f55771174dc79776839.tar.xz tailscale-b56058d7e32f6a0d6d163f55771174dc79776839.zip | |
tool/gocross: fix regression detecting when gocross needs rebuild
Fix regression from #8108 (Mar 2023). Since that change, gocross has
always been rebuilt on each run of ./tool/go (gocross-wrapper.sh),
adding ~100ms. (Well, not totally rebuilt; cmd/go's caching still
ends up working fine.)
The problem was $gocross_path was just "gocross", which isn't in my
path (and "." isn't in my $PATH, as it shouldn't be), so this line was
always evaluating to the empty string:
gotver="$($gocross_path gocross-version 2>/dev/null || echo '')"
The ./gocross is fine because of the earlier `cd "$repo_root"`
Updates tailscale/corp#21262
Updates tailscale/corp#21263
Change-Id: I80d25446097a3bb3423490c164352f0b569add5f
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Diffstat (limited to 'control/controlknobs/controlknobs.go')
0 files changed, 0 insertions, 0 deletions