diff options
| author | Brad Fitzpatrick <bradfitz@tailscale.com> | 2024-04-25 20:26:49 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <brad@danga.com> | 2024-04-25 20:45:57 -0700 |
| commit | cb66952a0d8e03ac7d73f5cfa84039a98c615594 (patch) | |
| tree | 8b56787f17d066150c75061697ba4be347301ca2 /control/controlknobs/controlknobs.go | |
| parent | 7349b274bdd1915b4229e0bde15849f3b6431655 (diff) | |
| download | tailscale-cb66952a0d8e03ac7d73f5cfa84039a98c615594.tar.xz tailscale-cb66952a0d8e03ac7d73f5cfa84039a98c615594.zip | |
health: permit Tracker method calls on nil receiver
In prep for tsd.System Tracker plumbing throughout tailscaled,
defensively permit all methods on Tracker to accept a nil receiver
without crashing, lest I screw something up later. (A health tracking
system that itself causes crashes would be no good.) Methods on nil
receivers should not be called, so a future change will also collect
their stacks (and panic during dev/test), but we should at least not
crash in prod.
This also locks that in with a test using reflect to automatically
call all methods on a nil receiver and check they don't crash.
Updates #11874
Updates #4136
Change-Id: I8e955046ebf370ec8af0c1fb63e5123e6282a9d3
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Diffstat (limited to 'control/controlknobs/controlknobs.go')
0 files changed, 0 insertions, 0 deletions
