diff options
| author | Brad Fitzpatrick <bradfitz@tailscale.com> | 2024-05-06 14:10:17 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <brad@danga.com> | 2024-05-06 15:03:06 -0700 |
| commit | f3d2fd22ef8c2d6df90a9d3ae7efc0105c9a00c1 (patch) | |
| tree | 4b21a44a12931688ec8bfc35e1155bca1fc1a7b6 /control/controlknobs/controlknobs.go | |
| parent | aadb8d9d21938110e34af35c28fe7324cef809e4 (diff) | |
| download | tailscale-f3d2fd22ef8c2d6df90a9d3ae7efc0105c9a00c1.tar.xz tailscale-f3d2fd22ef8c2d6df90a9d3ae7efc0105c9a00c1.zip | |
cmd/tailscale/cli: don't start WatchIPNBus until after up's initial Start
The CLI "up" command is a historical mess, both on the CLI side and
the LocalBackend side. We're getting closer to cleaning it up, but in
the meantime it was again implicated in flaky tests.
In this case, the background goroutine running WatchIPNBus was very
occasionally running enough to get to its StartLoginInteractive call
before the original goroutine did its Start call. That meant
integration tests were very rarely but sometimes logging in with the
default control plane URL out on the internet
(controlplane.tailscale.com) instead of the localhost control server
for tests.
This also might've affected new Headscale etc users on initial "up".
Fixes #11960
Fixes #11962
Change-Id: I36f8817b69267a99271b5ee78cb7dbf0fcc0bd34
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Diffstat (limited to 'control/controlknobs/controlknobs.go')
0 files changed, 0 insertions, 0 deletions