diff options
| author | Brad Fitzpatrick <bradfitz@tailscale.com> | 2024-07-06 19:29:58 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <brad@danga.com> | 2024-07-06 19:50:53 -0700 |
| commit | d2fef01206cd7a96d684f9c69ba9e767de824ab4 (patch) | |
| tree | 21d528e1b1a574e27baee49e6a98340f822de3e8 /control/controlknobs/controlknobs.go | |
| parent | 9df107f4f065bc4228949b3e3c3d08943722f91a (diff) | |
| download | tailscale-d2fef01206cd7a96d684f9c69ba9e767de824ab4.tar.xz tailscale-d2fef01206cd7a96d684f9c69ba9e767de824ab4.zip | |
control/controlknobs,tailcfg,wgengine/magicsock: remove DRPO shutoff switch
The DERP Return Path Optimization (DRPO) is over four years old (and
on by default for over two) and we haven't had problems, so time to
remove the emergency shutoff code (controlknob) which we've never
used. The controlknobs are only meant for new features, to mitigate
risk. But we don't want to keep them forever, as they kinda pollute
the code.
Updates #150
Change-Id: If021bc8fd1b51006d8bddd1ffab639bb1abb0ad1
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Diffstat (limited to 'control/controlknobs/controlknobs.go')
| -rw-r--r-- | control/controlknobs/controlknobs.go | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/control/controlknobs/controlknobs.go b/control/controlknobs/controlknobs.go index 9ff12c76f..bdbe5bdd2 100644 --- a/control/controlknobs/controlknobs.go +++ b/control/controlknobs/controlknobs.go @@ -19,10 +19,6 @@ type Knobs struct { // DisableUPnP indicates whether to attempt UPnP mapping. DisableUPnP atomic.Bool - // DisableDRPO is whether control says to disable the - // DERP route optimization (Issue 150). - DisableDRPO atomic.Bool - // KeepFullWGConfig is whether we should disable the lazy wireguard // programming and instead give WireGuard the full netmap always, even for // idle peers. @@ -110,7 +106,6 @@ func (k *Knobs) UpdateFromNodeAttributes(capMap tailcfg.NodeCapMap) { has := capMap.Contains var ( keepFullWG = has(tailcfg.NodeAttrDebugDisableWGTrim) - disableDRPO = has(tailcfg.NodeAttrDebugDisableDRPO) disableUPnP = has(tailcfg.NodeAttrDisableUPnP) randomizeClientPort = has(tailcfg.NodeAttrRandomizeClientPort) disableDeltaUpdates = has(tailcfg.NodeAttrDisableDeltaUpdates) @@ -136,7 +131,6 @@ func (k *Knobs) UpdateFromNodeAttributes(capMap tailcfg.NodeCapMap) { } k.KeepFullWGConfig.Store(keepFullWG) - k.DisableDRPO.Store(disableDRPO) k.DisableUPnP.Store(disableUPnP) k.RandomizeClientPort.Store(randomizeClientPort) k.OneCGNAT.Store(oneCGNAT) @@ -163,7 +157,6 @@ func (k *Knobs) AsDebugJSON() map[string]any { } return map[string]any{ "DisableUPnP": k.DisableUPnP.Load(), - "DisableDRPO": k.DisableDRPO.Load(), "KeepFullWGConfig": k.KeepFullWGConfig.Load(), "RandomizeClientPort": k.RandomizeClientPort.Load(), "OneCGNAT": k.OneCGNAT.Load(), |