diff options
| author | Brad Fitzpatrick <bradfitz@tailscale.com> | 2025-01-26 18:23:38 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <brad@danga.com> | 2025-01-26 18:49:11 +0000 |
| commit | e701fde6b389a4a69b4d33aace8969530b25de8d (patch) | |
| tree | c61e69301d643816bb7c794ff1827b6988345099 /control/controlknobs/controlknobs_test.go | |
| parent | 66b2e9fd07f2c635b809aa82d657fd82de3f9323 (diff) | |
| download | tailscale-e701fde6b389a4a69b4d33aace8969530b25de8d.tar.xz tailscale-e701fde6b389a4a69b4d33aace8969530b25de8d.zip | |
control/controlknobs: make Knobs.AsDebugJSON automatic, not require maintenance
The AsDebugJSON method (used only for a LocalAPI debug call) always
needed to be updated whenever a new controlknob was added. We had a
test for it, which was nice, but it was a tedious step we don't need
to do. Use reflect instead.
Updates #14788
Change-Id: If59cd776920f3ce7c748f86ed2eddd9323039a0b
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Diffstat (limited to 'control/controlknobs/controlknobs_test.go')
| -rw-r--r-- | control/controlknobs/controlknobs_test.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/control/controlknobs/controlknobs_test.go b/control/controlknobs/controlknobs_test.go index a78a486f3..7618b7121 100644 --- a/control/controlknobs/controlknobs_test.go +++ b/control/controlknobs/controlknobs_test.go @@ -6,6 +6,8 @@ package controlknobs import ( "reflect" "testing" + + "tailscale.com/types/logger" ) func TestAsDebugJSON(t *testing.T) { @@ -18,4 +20,5 @@ func TestAsDebugJSON(t *testing.T) { if want := reflect.TypeFor[Knobs]().NumField(); len(got) != want { t.Errorf("AsDebugJSON map has %d fields; want %v", len(got), want) } + t.Logf("Got: %v", logger.AsJSON(got)) } |