diff options
| author | Brad Fitzpatrick <bradfitz@tailscale.com> | 2025-10-02 12:01:59 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <brad@danga.com> | 2025-10-02 12:48:22 -0700 |
| commit | 24e38eb7294a057776a9942185460456ca1ebf95 (patch) | |
| tree | 1a4efba8fd2fdbd3ccc21d742006a6b5be9c0fb2 /control/controlknobs | |
| parent | a208cb9fd5ac7a3e8a7ca37daf0c1560ee84e35f (diff) | |
| download | tailscale-24e38eb7294a057776a9942185460456ca1ebf95.tar.xz tailscale-24e38eb7294a057776a9942185460456ca1ebf95.zip | |
control/controlclient,health,ipn/ipnlocal,health: fix deadlock by deleting health reporting
A recent change (009d702adfa0fc) introduced a deadlock where the
/machine/update-health network request to report the client's health
status update to the control plane was moved to being synchronous
within the eventbus's pump machinery.
I started to instead make the health reporting be async, but then we
realized in the three years since we added that, it's barely been used
and doesn't pay for itself, for how many HTTP requests it makes.
Instead, delete it all and replace it with a c2n handler, which
provides much more helpful information.
Fixes tailscale/corp#32952
Change-Id: I9e8a5458269ebfdda1c752d7bbb8af2780d71b04
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Diffstat (limited to 'control/controlknobs')
0 files changed, 0 insertions, 0 deletions