diff options
| author | Maisem Ali <maisem@tailscale.com> | 2023-09-02 12:04:03 -0700 |
|---|---|---|
| committer | Maisem Ali <maisem@gmail.com> | 2023-09-02 13:47:32 -0700 |
| commit | d06a75dcd0bba48fba5a5b5979f9490f5c1e718b (patch) | |
| tree | 10286a264b818e333ecec4378b2b81dc135ee095 /control/controlknobs | |
| parent | c6fadd6d71ac884e74bcedd3942576c397108093 (diff) | |
| download | tailscale-d06a75dcd0bba48fba5a5b5979f9490f5c1e718b.tar.xz tailscale-d06a75dcd0bba48fba5a5b5979f9490f5c1e718b.zip | |
ipn/ipnlocal: fix deadlock in resetControlClientLocked
resetControlClientLocked is called while b.mu was held and
would call cc.Shutdown which would wait for the observer queue
to drain.
However, there may be active callbacks from cc already waiting for
b.mu resulting in a deadlock.
This makes it so that resetControlClientLocked does not call
Shutdown, and instead just returns the value.
It also makes it so that any status received from previous cc
are ignored.
Updates tailscale/corp#12827
Signed-off-by: Maisem Ali <maisem@tailscale.com>
Diffstat (limited to 'control/controlknobs')
0 files changed, 0 insertions, 0 deletions